LinacAccNode will have XML Data Adaptor and a reference to the parent sequence#113
Merged
Conversation
1. Each LinacAccNode will have the copy of its own Data Adapter. It will allow to keep additional information for the future parsing if the user will need it. It could be PV names. In the SNS case it is the BPM length and orientation that we need for Online Model. The user could completely ignore the presence of this data. 2. The each AccNode will know its parent sequence. Before, only the level 1 nodes has this reference. Now we set it up even for children for consistency.
1. Each LinacAccNode will have the copy of its own Data Adapter. It will allow to keep additional information for the future parsing if the user will need it. It could be PV names. In the SNS case it is the BPM length and orientation that we need for Online Model. The user could completely ignore the presence of this data. 2. The each AccNode will know its parent sequence. Before, only the level 1 nodes has this reference. Now we set it up even for children for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two changes in the Linac nodes and lattice: