Open
Conversation
We'll need a newer one to use cmake binaries for riscv64. Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Fix policy definitions and minimum required CMake version in CMakeLists.txt so that we can build using riscv64 wheels. Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
This probably breaks, but let's test it out. Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Member
|
x265 and cmake patches should be in a separate PR since it benefits all builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the changes necessary to support riscv64 builds in pyav-ffmpeg. The work here is being done with the goal of supporting video_reader-rs using pyav-ffmpeg in its CI, which in turn is of interest to the RISE Project.
Note that there's a patch labeled
revertmewhich reduces the test matrix down to just riscv64 for testing purposes.I started by testing this on my fork: threexc#1
What I found there is that the manylinux build succeeds once cuda and amf are also disabled for riscv64, but musllinux is a different story. I looked to see what version of musl the musllinux_1_2 image includes:
Seems that the missing header (stdbit.h) is a C23 addition
I guess we'd need to wait for musl to support it, and then for a new musllinux_1_2 image to be built?
Alternatively, it looks like there's a compatibility layer for it in ffmpeg, which we could try to use.