Set up Vitest for unit testing#49
Open
FluxCapacitor2 wants to merge 7 commits intoconstructor-dependency-injectionfrom
Open
Set up Vitest for unit testing#49FluxCapacitor2 wants to merge 7 commits intoconstructor-dependency-injectionfrom
FluxCapacitor2 wants to merge 7 commits intoconstructor-dependency-injectionfrom
Conversation
…de effects when calling service functions from tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Vitest for unit testing and a GitHub Actions workflow that runs tests when files in the backend folder change.
Tests have access to a
createDBfunction that uses pglite to create an in-memory Postgres database. That way, each test has its own isolated database that doesn't leave behind files or require a separate process.While setting up the tests, I realized importing
env.tscauses the side effect of validating the environment variables, which will make any test fail. To address this, I moved environment variables to properties/constructor parameters of the service classes that they're in, so all accesses toenvnow happen withinservice/index.ts.So far, I just added one test that makes sure the test DB works properly - I'm not testing any actual functionality yet, but this PR is the first step. We should discuss which parts are most important to test and start there. I'm thinking createApp(Group), updateApp, githubWebhook, auth, updateDeployment, githubOAuthCallback, and githubInstallCallback are the most important/likely to break.