Merge pull request #569 from PubMatic/UOE-11010 by pm-nitin-shirsat · Pull Request #575 · PubMatic/OpenWrap

pm-nitin-shirsat · 2025-01-07T07:59:22Z

17th Dec release - Bid pooling

… resume execution

sync with nightly

Rebase with nightly

17th Dec release - Bid pooling

Phase 1.5 changes

Sync with nightly and taking phase 1.5 changes

… UOE-12755

Phase03 consent management changes

Merging Nightly 24nov into prebid upgrade branch

Yield Optimization & Consent Management Phase 03

Prebid upgrade 10.15

codacynew · 2026-01-13T06:22:36Z

src_new/constants.js

+	{ regex: /fxios\/([-\w\.]+)/i, id: 5 }, // Firefox for iOS
+	{ regex: /((?:fban\/fbios|fb_iab\/fb4a)(?!.+fbav)|;fbav\/([\w\.]+);)/i, id: 6 }, // Facebook In-App Browser
+	{ regex: / wv\).+(chrome)\/([\w\.]+)/i, id: 7 }, // Chrome WebView
+	{ regex: /droid.+ version\/([\w\.]+)\b.+(?:mobile safari|safari)/i, id: 8 }, // Android Browser


Codacy has a fix for the issue: Unnecessary escape character: ..

Suggested change

{ regex: /droid.+ version\/([\w\.]+)\b.+(?:mobile safari|safari)/i, id: 8 }, // Android Browser

{ regex: /droid.+ version\/([\w.]+)\b.+(?:mobile safari|safari)/i, id: 8 }, // Android Browser

codacynew · 2026-01-13T06:22:36Z

src_new/modules/consentConfigResolver.js

+// ===========================================
+var ConsentConstants = {
+  DEFAULT_CMP_LOOK_UP_TIMEOUT: 1000,
+  CONTINUOUS_CMP_CHECK_TIMEOUT: 15000,


Codacy has a fix for the issue: Expected indentation of 1 tab but found 2 spaces.

Suggested change

CONTINUOUS_CMP_CHECK_TIMEOUT: 15000,

CONTINUOUS_CMP_CHECK_TIMEOUT: 15000,

codacynew · 2026-01-13T06:22:37Z

src_new/constants.js

-	65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90];
+exports.REGEX_BROWSERS = [
+	{ regex: /\b(?:crios)\/([\w\.]+)/i, id: 1 }, // Chrome for iOS
+	{ regex: /(edg|edge)(?:e|ios|a)?(?:\/([\w\.]+))?/i, id: 2 }, // Edge


Codacy has a fix for the issue: Unnecessary escape character: ..

Suggested change

{ regex: /(edg|edge)(?:e|ios|a)?(?:\/([\w\.]+))?/i, id: 2 }, // Edge

{ regex: /(edg|edge)(?:e|ios|a)?(?:\/([\w.]+))?/i, id: 2 }, // Edge

codacynew · 2026-01-13T06:22:37Z

src_new/modules/consentConfigResolver.js

+          config.callbackFunctions.push(callbackFn);
+      },
+      getComplianceSupport: function () {
+        return config.complianceSupport;


Codacy has a fix for the issue: Expected indentation of 4 tabs but found 8 spaces.

Suggested change

return config.complianceSupport;

return config.complianceSupport;

codacynew · 2026-01-13T06:22:38Z

src_new/modules/consentConfigResolver.js

+        return config.complianceSupport;
+      },
+      getPrebidCMConfig: function () {
+        return config.prebidCMConfig;


Codacy has a fix for the issue: Expected indentation of 4 tabs but found 8 spaces.

Suggested change

return config.prebidCMConfig;

return config.prebidCMConfig;

codacynew · 2026-01-13T06:22:39Z

src_new/constants.js

+	{ regex: /((?:fban\/fbios|fb_iab\/fb4a)(?!.+fbav)|;fbav\/([\w\.]+);)/i, id: 6 }, // Facebook In-App Browser
+	{ regex: / wv\).+(chrome)\/([\w\.]+)/i, id: 7 }, // Chrome WebView
+	{ regex: /droid.+ version\/([\w\.]+)\b.+(?:mobile safari|safari)/i, id: 8 }, // Android Browser
+	{ regex: /(chrome|crios)(?:\/v?([\w\.]+))?\b/i, id: 9 }, // Chrome


Codacy has a fix for the issue: Unnecessary escape character: ..

Suggested change

{ regex: /(chrome|crios)(?:\/v?([\w\.]+))?\b/i, id: 9 }, // Chrome

{ regex: /(chrome|crios)(?:\/v?([\w.]+))?\b/i, id: 9 }, // Chrome

codacynew · 2026-01-13T06:22:39Z

src_new/modules/consentConfigResolver.js

+        cmpId: 0,                         // CMP ID: Consent Management Platform Id, default - 0
+        enforcedConsentBasisOn: ConsentConstants.CONSENT_MANAGEMENT_SOURCE.NONE,   // This will be used to enforce the consent basis on Possible values: 1 (CMP), 2 (GEO), 0 (NONE)
+        readGeoDataFrom: ConsentConstants.READ_GEO_DATA_FROM.NONE,                 // This will be used to identify the source of geo data read from Possible values: 1 (LOCALSTORAGE), 2 (GEO_SERVICE), 0 (NONE)
+        geoInfo: {                        // This will be used to store the geo information


Codacy has a fix for the issue: Expected indentation of 4 tabs but found 8 spaces.

Suggested change

geoInfo: { // This will be used to store the geo information

geoInfo: { // This will be used to store the geo information

codacynew · 2026-01-13T06:22:40Z

src_new/constants.js

+	{ regex: /\b(?:crios)\/([\w\.]+)/i, id: 1 }, // Chrome for iOS
+	{ regex: /(edg|edge)(?:e|ios|a)?(?:\/([\w\.]+))?/i, id: 2 }, // Edge
+	{ regex: /(opera|opr)(?:.+version\/|[\/ ]+)([\w\.]+)/i, id: 3 }, // Opera
+	{ regex: /(?:ms|\()(ie) ([\w\.]+)|(?:trident\/[\w\.]+)/i, id: 4 }, // Internet Explorer


Codacy has a fix for the issue: Unnecessary escape character: ..

Suggested change

{ regex: /(?:ms|\()(ie) ([\w\.]+)|(?:trident\/[\w\.]+)/i, id: 4 }, // Internet Explorer

{ regex: /(?:ms|\()(ie) ([\w.]+)|(?:trident\/[\w\.]+)/i, id: 4 }, // Internet Explorer

codacynew · 2026-01-13T06:22:40Z

src_new/modules/consentConfigResolver.js

-  NONE: "NONE"
-};
+  function createInstance() {
+    function getConfig() {


Codacy has a fix for the issue: Expected indentation of 2 tabs but found 4 spaces.

Suggested change

function getConfig() {

function getConfig() {

codacynew · 2026-01-13T06:22:41Z

src_new/common.util.js

+ */
+function getKeyByValue(obj, value) {
+	for (var key in obj) {
+		if (obj.hasOwnProperty(key)) {


Codacy has a fix for the issue: Do not access Object.prototype method 'hasOwnProperty' from target object.

Suggested change

if (obj.hasOwnProperty(key)) {

if (Object.prototype.hasOwnProperty.call(obj, key)) {

codacynew · 2026-01-13T06:22:42Z

src_new/modules/consentConfigResolver.js

+        geoMatchWithCMP: 2,               // This will be used to identify the geo match with CMP Possible values: 0 - Not Matched,1 - Matched, 2 - Not Concluded(default)
+        prebidCMConfig: {},               // This will be used to apply the consentManagement config to the Prebid instance
+        callbackFunctions: [],            // Functions to be called after the process is completed
+        continuousCmpCheck: {


Codacy has a fix for the issue: Expected indentation of 4 tabs but found 8 spaces.

Suggested change

continuousCmpCheck: {

continuousCmpCheck: {

codacynew · 2026-01-13T06:22:42Z

src_new/modules/consentConfigResolver.js

+      getComplianceSupport: function () {
+        return config.complianceSupport;
+      },
+      getPrebidCMConfig: function () {


Codacy has a fix for the issue: Expected indentation of 3 tabs but found 6 spaces.

Suggested change

getPrebidCMConfig: function () {

getPrebidCMConfig: function () {

codacynew · 2026-01-13T06:22:43Z

src_new/modules/consentConfigResolver.js

+    CMP: 1,
+    GEO: 2,
+    NONE: 0
+  },


Codacy has a fix for the issue: Expected indentation of 1 tab but found 2 spaces.

Suggested change

},

},

codacynew · 2026-01-13T06:22:44Z

src_new/constants.js

+	{ regex: /version\/([\w\.\,]+) .*mobile\/\w+ (safari)/i, id: 10 }, // Safari Mobile
+	{ regex: /version\/([\w(\.|\,)]+) .*(mobile ?safari|safari)/i, id: 11 }, // Safari
+	{ regex: /(firefox)\/([\w\.]+)/i, id: 12 } // Firefox
+  ];


Codacy has a fix for the issue: Expected indentation of 0 tabs but found 2 spaces.

Suggested change

];

];

codacynew · 2026-01-13T06:22:44Z

src_new/modules/consentConfigResolver.js

+  },
+  READ_GEO_DATA_FROM: {          // 1 -> LOCALSTORAGE, 2 -> GEO_SERVICE, 0 -> NONE
+    LOCALSTORAGE: 1,
+    GEO_SERVICE: 2,


Codacy has a fix for the issue: Expected indentation of 2 tabs but found 4 spaces.

Suggested change

GEO_SERVICE: 2,

GEO_SERVICE: 2,

codacynew · 2026-01-13T06:22:45Z

src_new/modules/consentConfigResolver.js

+    USP: 2,
+    GPP: 3
+  },
+  READ_GEO_DATA_FROM: {          // 1 -> LOCALSTORAGE, 2 -> GEO_SERVICE, 0 -> NONE


Codacy has a fix for the issue: Expected indentation of 1 tab but found 2 spaces.

Suggested change

READ_GEO_DATA_FROM: { // 1 -> LOCALSTORAGE, 2 -> GEO_SERVICE, 0 -> NONE

READ_GEO_DATA_FROM: { // 1 -> LOCALSTORAGE, 2 -> GEO_SERVICE, 0 -> NONE

codacynew · 2026-01-13T06:22:45Z

src_new/modules/consentConfigResolver.js

+          gsId: undefined                 // GPP section ID
+        },
+        geoMatchWithCMP: 2,               // This will be used to identify the geo match with CMP Possible values: 0 - Not Matched,1 - Matched, 2 - Not Concluded(default)
+        prebidCMConfig: {},               // This will be used to apply the consentManagement config to the Prebid instance


Codacy has a fix for the issue: Expected indentation of 4 tabs but found 8 spaces.

Suggested change

prebidCMConfig: {}, // This will be used to apply the consentManagement config to the Prebid instance

prebidCMConfig: {}, // This will be used to apply the consentManagement config to the Prebid instance

codacynew · 2026-01-13T06:22:46Z

src_new/modules/consentConfigResolver.js

+        callbackFunctions: [],            // Functions to be called after the process is completed
+        continuousCmpCheck: {
+          enabled: false,         // Continuous CMP checking enabled
+          timeout: ConsentConstants.CONTINUOUS_CMP_CHECK_TIMEOUT,         // Continuous CMP checking timeout         


Codacy has a fix for the issue: Expected indentation of 5 tabs but found 10 spaces.

Suggested change

timeout: ConsentConstants.CONTINUOUS_CMP_CHECK_TIMEOUT, // Continuous CMP checking timeout

timeout: ConsentConstants.CONTINUOUS_CMP_CHECK_TIMEOUT, // Continuous CMP checking timeout

codacynew · 2026-01-13T06:22:47Z

src_new/modules/consentConfigResolver.js

-};
+  function createInstance() {
+    function getConfig() {
+      return {


Codacy has a fix for the issue: Expected indentation of 3 tabs but found 6 spaces.

Suggested change

return {

return {

codacynew · 2026-01-13T06:22:47Z

src_new/modules/consentConfigResolver.js

+        complianceSupport: [],            // CMP's compliance supported,  1: GDPR, 2: USP, 3: GPP
+        cmpId: 0,                         // CMP ID: Consent Management Platform Id, default - 0
+        enforcedConsentBasisOn: ConsentConstants.CONSENT_MANAGEMENT_SOURCE.NONE,   // This will be used to enforce the consent basis on Possible values: 1 (CMP), 2 (GEO), 0 (NONE)
+        readGeoDataFrom: ConsentConstants.READ_GEO_DATA_FROM.NONE,                 // This will be used to identify the source of geo data read from Possible values: 1 (LOCALSTORAGE), 2 (GEO_SERVICE), 0 (NONE)


Codacy has a fix for the issue: Expected indentation of 4 tabs but found 8 spaces.

Suggested change

readGeoDataFrom: ConsentConstants.READ_GEO_DATA_FROM.NONE, // This will be used to identify the source of geo data read from Possible values: 1 (LOCALSTORAGE), 2 (GEO_SERVICE), 0 (NONE)

readGeoDataFrom: ConsentConstants.READ_GEO_DATA_FROM.NONE, // This will be used to identify the source of geo data read from Possible values: 1 (LOCALSTORAGE), 2 (GEO_SERVICE), 0 (NONE)

codacynew · 2026-01-13T06:22:48Z

src_new/constants.js

-exports.BROWSER_MAPPING = [1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,42,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,
-	65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90];
+exports.REGEX_BROWSERS = [
+	{ regex: /\b(?:crios)\/([\w\.]+)/i, id: 1 }, // Chrome for iOS


Codacy has a fix for the issue: Unnecessary escape character: ..

Suggested change

{ regex: /\b(?:crios)\/([\w\.]+)/i, id: 1 }, // Chrome for iOS

{ regex: /\b(?:crios)\/([\w.]+)/i, id: 1 }, // Chrome for iOS

codacynew · 2026-01-13T06:22:49Z

src_new/modules/consentConfigResolver.js

+        }
+      };
+    }
+    var config = getConfig();


Codacy has a fix for the issue: Expected indentation of 2 tabs but found 4 spaces.

Suggested change

var config = getConfig();

var config = getConfig();

codacynew · 2026-01-13T06:22:49Z

src_new/conf.js

-	bidderOrderingEnabled: "0"
+	bidderOrderingEnabled: "0",
+	cmEnabled: "1",
+  cmCmpApi: "iab",


Codacy has a fix for the issue: Expected indentation of 1 tab but found 2 spaces.

Suggested change

cmCmpApi: "iab",

cmCmpApi: "iab",

pm-nitin-shirsat and others added 30 commits October 10, 2024 23:04

Initial Implementation

5621e3a

GPP phase 02- small code changes

dce9e5d

gpp phase 02: Setting respective config

3164c74

gpp phase 02: Get away from multiple functions and move it to one

87cdd17

gpp phase 02: Improvise flow added some params for analysis purpose.

901b642

GPP phase 02: Pause the PWT execution and opnce identified or timeout…

f2c2438

… resume execution

GPP phase 02: Add support to IH

65740f3

resolving conflicts

51a4bf4

Merge pull request #564 from PubMatic/nightly

cd41214

sync with nightly

gpp phase 02: If consent management is not enabled then do not proceed

ea7722f

GPP Phase 02: Use NameSpace with global object

24ab41b

Add comments

9d6a22d

Add stats for the better logging

b9cfaeb

Updated code for GPP phase 02

b5f5815

Merge pull request #567 from PubMatic/nightly

b85a5bc

Rebase with nightly

Gpp Phase 02: Added time metrics module

2932e97

Import only that is required

40249fe

Merge pull request #569 from PubMatic/UOE-11010

c58b469

17th Dec release - Bid pooling

Update timeMetrics.js

097a004

Merge pull request #577 from PubMatic/UOE-11674

edf0b80

Phase 1.5 changes

Checking for schain object before setting schain in prebid

edca8e0

Merge branch 'standard_consent_management' into nightly_sync

b70454a

Merge pull request #580 from PubMatic/nightly_sync

fcfbb96

Sync with nightly and taking phase 1.5 changes

Sync with phase 02 changes

095b399

my commit message

4fd0077

Phase 02 changes

2599c6c

Improvements

08f7892

Remove usage of util and move to common-util.js

796a5a3

Handled empty object case and added test cases

2851be9

If consent is not enabled even local config should be available

d8c21da

pm-priyanka-deshmane and others added 7 commits November 12, 2025 15:51

Merge branch 'UOE-12755' of https://github.com/PubMatic/OpenWrap into…

10b1d40

… UOE-12755

Adding support only through hooks

0555b35

Merge pull request #619 from PubMatic/phase03-consent-management

2191fb9

Phase03 consent management changes

Merge pull request #621 from PubMatic/nightly_24nov

f75f5f6

Merging Nightly 24nov into prebid upgrade branch

Merge pull request #620 from PubMatic/nightly_24nov

d0ba37d

Yield Optimization & Consent Management Phase 03

Update gulpfile.js

ec536f9

Merge pull request #622 from PubMatic/openwrap_10_15_0_20251104145654

8fe8075

Prebid upgrade 10.15

codacynew bot reviewed Jan 13, 2026

View reviewed changes

	{ regex: /droid.+ version\/([\w\.]+)\b.+(?:mobile safari\|safari)/i, id: 8 }, // Android Browser
	{ regex: /droid.+ version\/([\w.]+)\b.+(?:mobile safari\|safari)/i, id: 8 }, // Android Browser

	CONTINUOUS_CMP_CHECK_TIMEOUT: 15000,
	CONTINUOUS_CMP_CHECK_TIMEOUT: 15000,

	{ regex: /(edg\|edge)(?:e\|ios\|a)?(?:\/([\w\.]+))?/i, id: 2 }, // Edge
	{ regex: /(edg\|edge)(?:e\|ios\|a)?(?:\/([\w.]+))?/i, id: 2 }, // Edge

	return config.complianceSupport;
	return config.complianceSupport;

	{ regex: /(chrome\|crios)(?:\/v?([\w\.]+))?\b/i, id: 9 }, // Chrome
	{ regex: /(chrome\|crios)(?:\/v?([\w.]+))?\b/i, id: 9 }, // Chrome

	geoInfo: { // This will be used to store the geo information
	geoInfo: { // This will be used to store the geo information

	{ regex: /(?:ms\|\()(ie) ([\w\.]+)\|(?:trident\/[\w\.]+)/i, id: 4 }, // Internet Explorer
	{ regex: /(?:ms\|\()(ie) ([\w.]+)\|(?:trident\/[\w\.]+)/i, id: 4 }, // Internet Explorer

	if (obj.hasOwnProperty(key)) {
	if (Object.prototype.hasOwnProperty.call(obj, key)) {

	getPrebidCMConfig: function () {
	getPrebidCMConfig: function () {

	READ_GEO_DATA_FROM: { // 1 -> LOCALSTORAGE, 2 -> GEO_SERVICE, 0 -> NONE
	READ_GEO_DATA_FROM: { // 1 -> LOCALSTORAGE, 2 -> GEO_SERVICE, 0 -> NONE

	prebidCMConfig: {}, // This will be used to apply the consentManagement config to the Prebid instance
	prebidCMConfig: {}, // This will be used to apply the consentManagement config to the Prebid instance

	timeout: ConsentConstants.CONTINUOUS_CMP_CHECK_TIMEOUT, // Continuous CMP checking timeout
	timeout: ConsentConstants.CONTINUOUS_CMP_CHECK_TIMEOUT, // Continuous CMP checking timeout

	readGeoDataFrom: ConsentConstants.READ_GEO_DATA_FROM.NONE, // This will be used to identify the source of geo data read from Possible values: 1 (LOCALSTORAGE), 2 (GEO_SERVICE), 0 (NONE)
	readGeoDataFrom: ConsentConstants.READ_GEO_DATA_FROM.NONE, // This will be used to identify the source of geo data read from Possible values: 1 (LOCALSTORAGE), 2 (GEO_SERVICE), 0 (NONE)

	{ regex: /\b(?:crios)\/([\w\.]+)/i, id: 1 }, // Chrome for iOS
	{ regex: /\b(?:crios)\/([\w.]+)/i, id: 1 }, // Chrome for iOS

Conversation

pm-nitin-shirsat commented Jan 7, 2025

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

codacynew bot Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants