Fix imageTag to image.tag in installation command#121
Fix imageTag to image.tag in installation command#121LinkMaq wants to merge 1 commit intoProject-HAMi:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: LinkMaq The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
✅ Deploy Preview for project-hami ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Welcome @LinkMaq! It looks like this is your first PR to Project-HAMi/website 🎉 |
There was a problem hiding this comment.
Pull request overview
This PR corrects the Helm installation parameter from scheduler.kubeScheduler.imageTag to scheduler.kubeScheduler.image.tag in the online installation documentation. This aligns with the nested structure shown in the Helm chart values where kubeScheduler.image is an object with a tag property.
Key Changes
- Updated the helm install command parameter syntax to use the correct nested property path
scheduler.kubeScheduler.image.tag
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ```bash | ||
| helm install hami hami-charts/hami --set scheduler.kubeScheduler.imageTag=v1.16.8 -n kube-system | ||
| helm install hami hami-charts/hami --set scheduler.kubeScheduler.image.tag=v1.16.8 -n kube-system |
There was a problem hiding this comment.
This change from scheduler.kubeScheduler.imageTag to scheduler.kubeScheduler.image.tag creates an inconsistency with line 25, which still references scheduler.kubeScheduler.imageTag. If image.tag is the correct parameter format, line 25 should also be updated to maintain consistency within this documentation.
1 participant
As described in the title, there is a little issue in the document.