Column creation mutation - support for "mirror" and "board_relation" column types + warnings#147
Open
Lewandowski-commits wants to merge 11 commits intoProdPerfect:masterfrom
Open
Column creation mutation - support for "mirror" and "board_relation" column types + warnings#147Lewandowski-commits wants to merge 11 commits intoProdPerfect:masterfrom
Lewandowski-commits wants to merge 11 commits intoProdPerfect:masterfrom
Conversation
Collaborator
|
Can you add unit tests as well? |
Fixed typo in line 36
…erations in batches.
Diosbejgli
reviewed
Mar 16, 2026
|
|
||
| Available methods | ||
| ^^^^^^^^^^^^^^^^^ | ||
| **Available methods:** |
Collaborator
There was a problem hiding this comment.
This way it'd become smaller, and less visible.
Author
There was a problem hiding this comment.
Diosbejgli
reviewed
Mar 16, 2026
Comment on lines
+35
to
+38
| Items Resource (monday.items) | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| ``create_item(board_id, group_id, item_name, column_values=None, create_labels_if_missing=False)`` | ||
| - Create an item on a board in the given group with name item_name. |
Collaborator
There was a problem hiding this comment.
Any specific reason you're changing this?
Author
Collaborator
There was a problem hiding this comment.
yeah, you can just exclude the README changes altogether.
Diosbejgli
reviewed
Mar 16, 2026
Collaborator
Diosbejgli
left a comment
Diosbejgli
left a comment
There was a problem hiding this comment.
Can you add unit tests for your change?
Author
Diosbejgli
reviewed
Mar 17, 2026
|
|
||
| _DEFAULT_HEADERS = { | ||
| "API-Version": "2023-10" | ||
| "API-Version": "2026-01" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the support for mirror and board_relation columns.
This is only supported on the current API version of 2026-01, so I've also updated the default API version in the client.
Since the creation of these columns is possible without the defaults that will actually create the links to specific boards/columns/items, I've also added warnings if a create_column mutation for these column types is ran without the key defaults for them.
Looks like there's already #132 for improving the queries on those column types, so both PRs could be potentially combined.