-
Notifications
You must be signed in to change notification settings - Fork 37
Add GLIBC_MIN_VERSION preprocessor definitions for CMake builds #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
5
commits into
master
Choose a base branch
from
copilot/add-glibc-min-version-to-cmake
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: adityapatwardhan <12820925+adityapatwardhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add -DGLIBC_MIN_VERSION for CMake files
Add GLIBC_MIN_VERSION preprocessor definitions to CMake build
Jan 27, 2026
Co-authored-by: adityapatwardhan <12820925+adityapatwardhan@users.noreply.github.com>
Copilot
AI
changed the title
Add GLIBC_MIN_VERSION preprocessor definitions to CMake build
Add GLIBC_MIN_VERSION preprocessor definitions for CMake builds
Jan 27, 2026
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
daxian-dbw
approved these changes
Jan 27, 2026
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
-DGLIBC_MIN_VERSIONcompiler flag to specify minimum GLIBC requirements at build time.Changes
GLIBC_MIN_VERSION=2.27for default buildsGLIBC_MIN_VERSION=2.35for ARM32 (armv7l)GLIBC_MIN_VERSION=2.27for ARM64 (aarch64)The preprocessor definition is added to
CMAKE_CXX_FLAGSandCMAKE_CXX_COMPILERfollowing existing patterns for flags like-D_FORTIFY_SOURCE=2.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.