Open
Conversation
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
Member
figueroa1395
left a comment
figueroa1395
left a comment
There was a problem hiding this comment.
Final remark, can you add a unit test with an input dataset with faults and then create an output dataset for state estimation based on it? Additionally another one, but for an input dataset with some sensors and and output dataset for short circuit calculations.
power_grid_model_c/power_grid_model_cpp/include/power_grid_model_cpp/dataset.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model_cpp/include/power_grid_model_cpp/dataset.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model_cpp/include/power_grid_model_cpp/dataset.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model_cpp/include/power_grid_model_cpp/dataset.hpp
Show resolved
Hide resolved
power_grid_model_c/power_grid_model_cpp/include/power_grid_model_cpp/dataset.hpp
Show resolved
Hide resolved
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
nitbharambe
reviewed
Mar 25, 2026
power_grid_model_c/power_grid_model_cpp/include/power_grid_model_cpp/dataset.hpp
Outdated
Show resolved
Hide resolved
nitbharambe
reviewed
Mar 25, 2026
power_grid_model_c/power_grid_model_cpp/include/power_grid_model_cpp/dataset.hpp
Outdated
Show resolved
Hide resolved
Member
|
@figueroa1395 done with the review. |
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1339
Also with some refactor in enums in validation test.