Fix Codex review base prompt compatibility#154
Open
Horacehxw wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the RLCR Codex review flow to stay compatible with Codex 0.130.0 behavior when --base is used, and adds regression coverage to prevent reintroducing prompt/stdin input in that mode.
Changes:
- Add regression assertions that nested
codex review --base ...is invoked without prompt input (-arg) and without stdin. - Update the review audit prompt template (and fallback text) to document the Codex 0.130.0
--base+ prompt incompatibility. - Make cache-path test computation use canonicalized project roots and add guarded Bash array expansions in nested Codex/template paths.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/test-finalize-phase.sh |
Aligns cache path computation with hook logic by canonicalizing the test directory before sanitization. |
tests/test-disable-nested-codex-hooks.sh |
Adds regression coverage ensuring codex review --base is not given prompt input (-) or stdin, and verifies audit prompt wording. |
prompt-template/codex/code-review-phase.md |
Documents the Codex 0.130.0 incompatibility in the generated audit prompt template. |
hooks/loop-codex-stop-hook.sh |
Updates audit prompt fallback wording and guards array expansions for nested Codex invocations/logging. |
hooks/lib/template-loader.sh |
Guards empty array expansion when constructing env arguments for template rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zevorn
reviewed
May 12, 2026
| "--base arguments with no trailing '-' and no stdin" "$(cat "$TEST_DIR/review.args" 2>/dev/null || echo missing)" | ||
| fi | ||
|
|
||
| REVIEW_PROMPT="$REPO_REVIEW/.humanize/rlcr/2026-03-14_12-00-00/round-2-review-prompt.md" |
Contributor
There was a problem hiding this comment.
Why is PERVIEW_PROMPT a fixed path?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codex review --base ... -and stdin prompt input--base+[PROMPT]incompatibilityVerification
git diff --check HEAD~1..HEADbash tests/test-disable-nested-codex-hooks.shbash tests/test-templates-comprehensive.shbash tests/test-finalize-phase.shNote:
bash tests/run-all-tests.shis not a valid aggregate verification on this macOS host because the runner uses Bash 4 associative arrays while /bin/bash is 3.2.57.