-
Notifications
You must be signed in to change notification settings - Fork 50
Add gen-idea skill to Codex installs #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zhaoxueyan1
wants to merge
3
commits into
PolyArch:dev
Choose a base branch
from
zhaoxueyan1:codex/gen-idea-codex-skill
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # Finalize Phase | ||
|
|
||
| Codex review has passed. The implementation is complete and all acceptance criteria have been met. | ||
|
|
||
| You are now in the **Finalize Phase**. This is the opportunity to simplify and refactor the code before final completion. | ||
|
|
||
| ## Your Task | ||
|
|
||
| Use the Codex `code-simplifier:code-simplifier` agent if it is available in the current runtime. If that agent is not available, perform the same simplification pass directly in this session. | ||
|
|
||
| ## Constraints | ||
|
|
||
| These constraints are **non-negotiable**: | ||
|
|
||
| 1. **Must NOT change existing functionality** - All features must work exactly as before | ||
| 2. **Must NOT fail existing tests** - Run tests to verify nothing is broken | ||
| 3. **Must NOT introduce new bugs** - Be careful with refactoring | ||
| 4. **Only perform functionality-equivalent changes** - Simplification and cleanup only | ||
|
|
||
| ## Focus Areas | ||
|
|
||
| Focus on: | ||
| - Code that was recently added or modified | ||
| - Changes between branch from `{{BASE_BRANCH}}` to `{{START_BRANCH}}` | ||
| - Removing unnecessary complexity | ||
| - Improving readability and maintainability | ||
| - Consolidating duplicate code | ||
| - Simplifying control flow where possible | ||
| - Removing dead code or unused variables | ||
|
|
||
| ## Reference Files | ||
|
|
||
| - Original plan: @{{PLAN_FILE}} | ||
| - Goal tracker: @{{GOAL_TRACKER_FILE}} | ||
|
|
||
| ## Before Exiting | ||
|
|
||
| 1. Complete all `[mainline]` and `[blocking]` tasks | ||
| 2. `[queued]` tasks may remain only if they are documented as non-blocking follow-up work | ||
| 3. Commit your changes with a descriptive message | ||
| 4. Write your finalize summary to: **{{FINALIZE_SUMMARY_FILE}}** | ||
|
|
||
| Your summary should include: | ||
| - What simplifications were made | ||
| - Files modified during the Finalize Phase | ||
| - Confirmation that tests still pass | ||
| - Any notes about the refactoring decisions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| # Finalize Phase (Review Skipped) | ||
|
|
||
| **Warning**: Code review was skipped due to: {{REVIEW_SKIP_REASON}} | ||
|
|
||
| The implementation could not be fully validated. You are now in the **Finalize Phase**. | ||
|
|
||
| ## Important Notice | ||
|
|
||
| Since the code review was skipped, manually verify your changes before finalizing: | ||
|
|
||
| 1. Review your code changes for any obvious issues | ||
| 2. Run any available tests to verify correctness | ||
| 3. Check for common code quality issues | ||
|
|
||
| ## Simplification (Optional) | ||
|
|
||
| If time permits, use the Codex `code-simplifier:code-simplifier` agent if it is available in the current runtime. If that agent is not available, perform the same simplification pass directly in this session. | ||
|
|
||
| Focus on changes between branch from `{{BASE_BRANCH}}` to `{{START_BRANCH}}`. | ||
|
|
||
| ## Constraints | ||
|
|
||
| These constraints are **non-negotiable**: | ||
|
|
||
| 1. **Must NOT change existing functionality** - All features must work exactly as before | ||
| 2. **Must NOT fail existing tests** - Run tests to verify nothing is broken | ||
| 3. **Must NOT introduce new bugs** - Be careful with refactoring | ||
| 4. **Only perform functionality-equivalent changes** - Simplification and cleanup only | ||
|
|
||
| ## Reference Files | ||
|
|
||
| - Original plan: @{{PLAN_FILE}} | ||
| - Goal tracker: @{{GOAL_TRACKER_FILE}} | ||
|
|
||
| ## Before Exiting | ||
|
|
||
| 1. Complete all `[mainline]` and `[blocking]` tasks | ||
| 2. `[queued]` tasks may remain only if they are documented as non-blocking follow-up work | ||
| 3. Commit your changes with a descriptive message | ||
| 4. Write your finalize summary to: **{{FINALIZE_SUMMARY_FILE}}** | ||
|
|
||
| Your summary should include: | ||
| - What work was done | ||
| - Files modified | ||
| - Confirmation that tests still pass, if possible | ||
| - Any notes about manual verification performed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| # Methodology Analysis Phase | ||
|
|
||
| The RLCR loop has reached its exit point. | ||
|
|
||
| **Exit reason**: {{EXIT_REASON}} - {{EXIT_REASON_DESCRIPTION}} | ||
| **Rounds completed**: {{CURRENT_ROUND}} of {{MAX_ITERATIONS}} | ||
|
|
||
| Before the loop fully exits, perform a methodology improvement analysis. This analysis helps improve the Humanize development methodology itself -- it is NOT about the project you just worked on. | ||
|
|
||
| ## Instructions | ||
|
|
||
| ### 1. Run a Sanitized Codex 5.5 Analysis | ||
|
|
||
| Use a Codex analysis sub-agent running `gpt-5.5` when the current runtime supports explicit model selection. If explicit model selection or sub-agent execution is unavailable, perform the analysis directly in this Codex session and note that fallback in the report. | ||
|
|
||
| Analysis task: Read the development records in `{{LOOP_DIR}}`: | ||
| - All files matching `round-*-summary.md` | ||
| - All files matching `round-*-review-result.md` | ||
|
|
||
| Analyze these records from a **pure methodology perspective** and write your findings to `{{LOOP_DIR}}/methodology-analysis-report.md`. | ||
|
|
||
| **CRITICAL SANITIZATION RULES** - The report MUST NOT contain: | ||
| - File paths, directory paths, or module paths | ||
| - Function names, variable names, class names, or method names | ||
| - Branch names, commit hashes, or git identifiers | ||
| - Business domain terms, product names, or feature names | ||
| - Code snippets or code fragments of any kind | ||
| - Raw error messages or stack traces | ||
| - Project-specific URLs or endpoints | ||
| - Any information that could identify the specific project | ||
|
|
||
| **Focus areas for analysis**: | ||
| - Iteration efficiency: Were rounds productive or did they repeat similar work? | ||
| - Feedback loop quality: Did reviewer feedback lead to meaningful improvements? | ||
| - Stagnation patterns: Were there signs of going in circles? | ||
| - Review effectiveness: Did reviews catch real issues or create false positives? | ||
| - Plan-to-execution alignment: Did execution follow the plan or drift? | ||
| - Round count vs. progress ratio: Was the number of rounds proportional to progress? | ||
| - Communication clarity: Were summaries and reviews clear and actionable? | ||
|
|
||
| **Output format**: Write a structured report with methodology improvement suggestions. Each suggestion should describe a general pattern observed and a concrete improvement to the RLCR methodology. If no improvements are found, write a brief note saying the methodology worked well for this session. | ||
|
|
||
| ### 2. Read the Analysis Report | ||
|
|
||
| After the analysis completes, read `{{LOOP_DIR}}/methodology-analysis-report.md`. ALL subsequent user-facing content MUST be derived solely from this report -- do NOT reference raw development records directly. | ||
|
|
||
| ### 3. Handle Results | ||
|
|
||
| **If no improvements found**: Briefly inform the user that the methodology analysis found no significant improvement suggestions. Then write a completion note to `{{LOOP_DIR}}/methodology-analysis-done.md` and exit. | ||
|
|
||
| **If improvements found**: | ||
|
|
||
| a) Report to the user: | ||
| - Brief summary of the exit reason ({{EXIT_REASON}}: {{EXIT_REASON_DESCRIPTION}}) | ||
| - Methodology improvement suggestions from the report | ||
|
|
||
| b) Ask the user directly whether they would like to help improve Humanize by opening a GitHub issue with these suggestions. Emphasize: | ||
| - This is completely voluntary | ||
| - The content is fully sanitized with no project-specific information | ||
| - It helps improve the methodology for everyone | ||
|
|
||
| c) **If user declines**: Write a completion marker to `{{LOOP_DIR}}/methodology-analysis-done.md` and exit. | ||
|
|
||
| d) **If user agrees**: | ||
| - Draft a GitHub issue title and body from the analysis report | ||
| - Show the draft to the user for review and confirmation | ||
| - If confirmed: run `gh issue create --repo PolyArch/humanize --title "..." --body "..."` | ||
| - If `gh` is not available, provide the title and body so the user can create the issue manually | ||
| - Write a completion marker to `{{LOOP_DIR}}/methodology-analysis-done.md` and exit | ||
|
|
||
| ### 4. Completion Marker | ||
|
|
||
| You MUST write meaningful content to `{{LOOP_DIR}}/methodology-analysis-done.md` before exiting. This file signals that the analysis phase is complete. A brief summary of what was done, such as "Analysis complete, no suggestions" or "Analysis complete, issue filed", is sufficient. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.