Open
Conversation
MaxGhenis
requested changes
Aug 31, 2025
Collaborator
MaxGhenis
left a comment
MaxGhenis
left a comment
There was a problem hiding this comment.
only rules in this repo
MaxGhenis
requested changes
Sep 1, 2025
Collaborator
MaxGhenis
left a comment
MaxGhenis
left a comment
There was a problem hiding this comment.
great to see this passing checks!
| definition_period = YEAR | ||
| unit = GBP | ||
| documentation = "Total VAT charged on firm's sales (output VAT)" | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| defined_for = "firm_vat_registered" | |
| quantity_type = FLOW | ||
|
|
||
|
|
||
| class annual_input_k(Variable): |
Collaborator
There was a problem hiding this comment.
make all numbers pounds not thousands
| description = "Business firm variables from firm dataset." | ||
|
|
||
|
|
||
| class firm_id(Variable): |
Collaborator
There was a problem hiding this comment.
make each variable its own file
Collaborator
There was a problem hiding this comment.
don't think we need this or business_group - we're only targeting at this level not simulating at it
| turnover = firm("annual_turnover_k", period) * 1000 | ||
| threshold = parameters(period).gov.hmrc.vat.registration_threshold | ||
|
|
||
| return turnover > threshold |
Collaborator
There was a problem hiding this comment.
they can choose to register if under right? can be beneficial?
if so we may need another variable here that's from the calibrated dataset like registers_for_vat_if_not_required
| output_vat = firm("firm_vat_on_sales", period) | ||
| input_vat = firm("firm_vat_on_purchases", period) | ||
|
|
||
| return output_vat - input_vat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1333