Draft
Conversation
esa_income is a BenUnit variable, so must be aggregated to household using household_from_family() not household_from_person(). The size mismatch (benunit count vs person count) caused the obr/esa target to be skipped during calibration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esa_incomeis aBenUnit-level variable, butcompute_esawas passing it tohousehold_from_person(), which expects person-level arraysobr/esacalibration target on every buildhousehold_from_family()foresa_income;esa_contribisPerson-level so remains unchangedChanges
policyengine_uk_data/targets/compute/income.py:household_from_person→household_from_familyforesa_income