Handle ParameterNotFoundError gracefully in runner#709
Open
PavelMakarchuk wants to merge 1 commit intomainfrom
Open
Handle ParameterNotFoundError gracefully in runner#709PavelMakarchuk wants to merge 1 commit intomainfrom
PavelMakarchuk wants to merge 1 commit intomainfrom
Conversation
The runner crashed on PA records for 2024 because state_eitc triggers a ParameterNotFoundError for pa_eitc.match. The error handler only caught "does not exist" but not "was not found". Now catches both, matching exe.py behavior of returning 0 for missing parameters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state_eitctriggers aParameterNotFoundErrorforpa_eitc.match"does not exist"but not"was not found"— now catches bothContext
Found while testing the runner as a replacement for exe.py in response to #706 (speed issue). Without this fix, any input containing Pennsylvania records for 2024 crashes the runner.
Test plan
🤖 Generated with Claude Code