fix: Remove label constraint from parameter seeding#59
Open
fix: Remove label constraint from parameter seeding#59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[0].rate) and breakdown parameters (e.g.,.SINGLE,.CA) don't have explicit labels in their YAML filesChanges
scripts/seed.py: Removedp.label is Nonecheck from parameter filtering looptest_fixtures/fixtures_parameters.py: Madelabelparameter optional increate_parameter()tests/test_parameters.py: Added two tests verifying parameters without labels work correctlyTest plan
pytest tests/test_parameters.py- all 11 tests passFixes #58
Will be accompanied by a PR in
.pyto automatically assign labels to brackets and breakdown parameters and a PR in-usto apply labels to unlabelled parameters.🤖 Generated with Claude Code