Conversation
ptomecek
requested review from
AdamGlustein,
alexddobkin,
robambalu,
svatasoiu and
timkpaine
as code owners
timkpaine
requested changes
Nov 15, 2024
Member
There was a problem hiding this comment.
I have explicitly checked that the tests pass under versions 2.10.1 and 3.1.4
We have a spot for dependency version checks, lets add this there
ptomecek
commented
Nov 15, 2024
timkpaine
reviewed
Nov 15, 2024
timkpaine
previously approved these changes
Nov 16, 2024
AdamGlustein
requested changes
Nov 16, 2024
Collaborator
AdamGlustein
left a comment
AdamGlustein
left a comment
There was a problem hiding this comment.
Minor feedback. I'm not too familiar with the actual Perspective 3.0 API changes but I'll accept @timkpaine 's approval on those.
Signed-off-by: Pascal Tomecek <pascal.tomecek@cubistsystematic.com> Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
ptomecek
force-pushed
the
pit/psp3
branch
4 times, most recently
from
3651e42 to
d86de08
Compare
robambalu
reviewed
Nov 18, 2024
ptomecek
force-pushed
the
pit/psp3
branch
2 times, most recently
from
d0641ea to
e0a1277
Compare
Signed-off-by: Pascal Tomecek <pascal.tomecek@cubistsystematic.com>
robambalu
approved these changes
Nov 19, 2024
AdamGlustein
approved these changes
Nov 19, 2024
timkpaine
added
type: enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks to @sinistersnare for #370 which I relied on heavily for this PR.
Some key differences from that PR are:
to_dataframefunction on the viewlocalizeoption that allows for local timestamps in perspective, as it doesn't make sense on perspective 3.I have explicitly checked that the tests pass under versions 2.10.1 and 3.1.4