Computer Group Site Assignment BugFix #66#72
Open
cybertunnel wants to merge 1 commit intoPixarAnimationStudios:masterfrom
cybertunnel:bugfix/#66
Open
Computer Group Site Assignment BugFix #66#72cybertunnel wants to merge 1 commit intoPixarAnimationStudios:masterfrom cybertunnel:bugfix/#66
cybertunnel wants to merge 1 commit intoPixarAnimationStudios:masterfrom
cybertunnel:bugfix/#66
Conversation
glenfarclas17
requested changes
Nov 9, 2020
Contributor
glenfarclas17
left a comment
glenfarclas17
left a comment
There was a problem hiding this comment.
Heya Tyler!
I'm finally looking at all of your pending merges.
This one is a problem, cuz you're adding a 'computer' element in the parent class of all groups, which might be a MobileDeviceGroup or a UserGroup.
The way I'd do it is:
group.add_element(self.class::MEMBER_CLASS::RSRC_LIST_KEY.to_s).text = nil
self.class::MEMBER_CLASS::RSRC_LIST_KEY.to_s should return 'computers', 'mobile_devices', or 'users' as appropriate for the Group subclass being used.
Cheers,
-Chris
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix the bug outlined in #66 where the smart group wouldn't properly update and throw a 409.
The changes made:
Details:
The Jamf Pro API assumes you want the same computers included in the group if you don't specify the
<computers><computer /></computers>section of the XML payload. This is why we get a 409 since one or more computers in the group might not be assigned to the site the group is being moved to.