Fix Ancestral and Seismic Cry incorrectly granting damage with Echoes of Creation to some skills#9464
Open
LocalIdentity wants to merge 1 commit intodevfrom
Open
Fix Ancestral and Seismic Cry incorrectly granting damage with Echoes of Creation to some skills#9464LocalIdentity wants to merge 1 commit intodevfrom
LocalIdentity wants to merge 1 commit intodevfrom
Conversation
Exerts for Seismic and Ancestral Cry were being applied to any skill instead of just slam skills so when the code in Calc Perform went to count the number of Warcries that were exerting a skill, those 2 warcries would count for all melee skills Now filter the skill types that those 2 can exert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9463
Description of the problem being solved:
Exerts for Seismic and Ancestral Cry were being applied to any skill instead of just slam skills so when the code in Calc Perform went to count the number of Warcries that were exerting a skill, those 2 warcries would count for all melee skills
Now filter the skill types that those 2 can exert
Link to a build that showcases this PR:
https://pobb.in/RSWyXC5ivo2t
Before screenshot:
After screenshot: