Ensure (ux)fieldset has both UV and UVW for datasets with U, V, and W#2505
Open
fluidnumerics-joe wants to merge 3 commits intov4-devfrom
Open
Ensure (ux)fieldset has both UV and UVW for datasets with U, V, and W#2505fluidnumerics-joe wants to merge 3 commits intov4-devfrom
fluidnumerics-joe wants to merge 3 commits intov4-devfrom
Conversation
Co-authored-by: Erik van Sebille <e.vansebille@uu.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch ensures that
FieldSetobjects created from datasets containing U, V, and W velocity components have bothUVandUVWvector fields available.Changes
Bug Fix: Missing UV VectorField for 3D velocity datasets
Previously, when a dataset contained all three velocity components (U, V, W), only the
UVWVectorField was created. This meant users could not access a 2DUVVectorField for horizontal-only advection without manually creating one.Now, both
UVandUVWVectorFields are automatically created when all three components are present, providing flexibility for both 2D and 3D advection use cases.