Skip to content

feat: Add per-server forwarding configuration in Velocity#453

Open
Timongcraft wants to merge 3 commits intoPaperMC:mainfrom
Timongcraft:feat/velocity-individual-forward-mode
Open

feat: Add per-server forwarding configuration in Velocity#453
Timongcraft wants to merge 3 commits intoPaperMC:mainfrom
Timongcraft:feat/velocity-individual-forward-mode

Conversation

@Timongcraft
Copy link
Contributor

@Timongcraft Timongcraft commented Jul 22, 2024 •
edited
Loading

Reflect changes from Velocity#1357.

Prequirement:

  • This PR requires Velocity#1357 to be merged before this one can be finalized.

@github-actions
Copy link

github-actions bot commented Jul 22, 2024 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
papermc-docs ✅ Ready (View Log) Visit Preview 0a103f1

powercasgamer
powercasgamer suggested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@powercasgamer powercasgamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have examples, ans show how to migrate from before to the new format.

@Timongcraft
Copy link
Contributor Author

Timongcraft commented Jul 22, 2024

Should have examples, ans show how to migrate from before to the new format.

Where would you suggest a migration guide should be added?
Should it be included directly in the forwarding guide, or would it be better to use /velocity/migration, even though it seems rather unused?

@Timongcraft
Copy link
Contributor Author

Timongcraft commented Jul 22, 2024

@powercasgamer, do you think this is good?

zlataovce
zlataovce requested changes Jul 22, 2024
View reviewed changes
@Timongcraft Timongcraft marked this pull request as ready for review July 24, 2024 23:14
@Timongcraft
Copy link
Contributor Author

Timongcraft commented Jul 24, 2024 •
edited
Loading

The 'blocked by feature' label should be removed, as it is no longer blocked.

@Nacioszeczek
Copy link
Contributor

Nacioszeczek commented Jul 24, 2024

The 'blocked by feature' label should be removed, as it is no longer blocked.

The Velocity PR is not merged.

@Timongcraft
Copy link
Contributor Author

Timongcraft commented Jul 24, 2024

The 'blocked by feature' label should be removed, as it is no longer blocked.

The Velocity PR is not merged.

You're right, I messed up.

@Timongcraft Timongcraft changed the title feat: Add per-server forwarding configuration feat: Add per-server forwarding configuration in Velocity Aug 19, 2024
@Timongcraft Timongcraft force-pushed the feat/velocity-individual-forward-mode branch from 6221dfc to 0a103f1 Compare April 21, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zlataovce zlataovce zlataovce requested changes

+1 more reviewer

@powercasgamer powercasgamer powercasgamer requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

blocked by feature project: Velocity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Timongcraft @Nacioszeczek @zlataovce @powercasgamer @Strokkur424