Skip to content

Get api url into an env var #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kookster merged 2 commits into from
Mar 24, 2026
Merged

Get api url into an env var #887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f91b4b
Get api url into an env var
kookster Mar 23, 2026
a2be3fa
Make aud name value a param as well
kookster Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions spire/templates/apps-200A.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,8 @@ Resources:
EchoServiceToken: !Ref EchoServiceToken
SlackMessageRelaySnsTopicArn: !Ref SlackMessageRelaySnsTopicArn
Aarch64AsgCapacityProviderName: !Ref Aarch64AsgCapacityProviderName
ApplePodcastsConnectApiUrl: !Sub /prx/${EnvironmentTypeAbbreviation}/Spire/Dovetail-Feeder/apple-podcasts-connect-api-url
ApplePodcastsConnectApiAudName: !Sub /prx/${EnvironmentTypeAbbreviation}/Spire/Dovetail-Feeder/apple-podcasts-connect-api-aud-name
Tags:
- { Key: prx:meta:tagging-version, Value: "2021-04-07" }
- { Key: prx:cloudformation:stack-name, Value: !Ref AWS::StackName }
Expand Down
12 changes: 11 additions & 1 deletion spire/templates/apps/feeder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,8 @@ Parameters:
DovetailAppleApiBridgeEndpointUrl: { Type: String }
SlackMessageRelaySnsTopicArn: { Type: String }
Aarch64AsgCapacityProviderName: { Type: String }
ApplePodcastsConnectApiUrl: { Type: AWS::SSM::Parameter::Value<String> }
ApplePodcastsConnectApiAudName: { Type: AWS::SSM::Parameter::Value<String> }

Conditions:
IsProduction: !Equals [!Ref EnvironmentType, Production]
Expand Down Expand Up @@ -905,6 +907,10 @@ Resources:
Value: !Ref S3SigningAccessKeyId
- Name: UPLOAD_SIGNING_SERVICE_URL
Value: !Ref S3SigningEndpointUrl
- Name: APPLE_PODCASTS_CONNECT_API_URL
Value: !Ref ApplePodcastsConnectApiUrl
- Name: APPLE_PODCASTS_CONNECT_API_AUD_NAME
Value: !Ref ApplePodcastsConnectApiAudName
Essential: true
Image: !Sub ${AWS::AccountId}.dkr.ecr.${AWS::Region}.amazonaws.com/${EcrImageTag}
LinuxParameters:
Expand Down Expand Up @@ -1091,9 +1097,13 @@ Resources:
Value: !Ref FeederUploadsBucket
- Name: WORKER_COUNT
Value: !If [IsProduction, 8, 5]
- Name: APPLE_PODCASTS_CONNECT_API_URL
Value: !Ref ApplePodcastsConnectApiUrl
- Name: APPLE_PODCASTS_CONNECT_API_AUD_NAME
Value: !Ref ApplePodcastsConnectApiAudName
Essential: true
HealthCheck:
Command: [ "CMD-SHELL", "pgrep -f shoryuken || exit 1" ]
Command: ["CMD-SHELL", "pgrep -f shoryuken || exit 1"]
Interval: 30
Retries: 3
StartPeriod: 15
Expand Down