Skip to content

Support cross-account Kinesis stream for Counts #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
farski merged 7 commits into from
Mar 18, 2026
Merged

Support cross-account Kinesis stream for Counts #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
df61109
Add Kinesis stream policy to CDN logs stream
farski Mar 16, 2026
e95c24c
Add second Kinesis stream trigger to Counts function
farski Mar 16, 2026
bac60a8
Fix stream event conditions
farski Mar 17, 2026
88d84ec
Remove invalid action
farski Mar 18, 2026
32accbc
Switch to explicit principal
farski Mar 18, 2026
3d29fa4
Use region-specific Kinesis parameters
farski Mar 18, 2026
4a9725c
Fix param path
farski Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions cdn/dovetail-cdn/real-time-logs-kinesis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,29 @@ Resources:
- { Key: prx:ops:environment, Value: !Ref EnvironmentType }
- { Key: prx:dev:family, Value: Dovetail }
- { Key: prx:dev:application, Value: Counts }
CloudfrontRealTimeLogsStreamPolicy:
Type: AWS::Kinesis::ResourcePolicy
Properties:
ResourceArn: !GetAtt CloudfrontRealTimeLogsStream.Arn
ResourcePolicy:
Statement:
- Action:
- kinesis:DescribeStream
- kinesis:DescribeStreamSummary
- kinesis:GetRecords
- kinesis:GetShardIterator
- kinesis:ListShards
Condition:
StringEquals:
aws:ResourceOrgID: ${aws:PrincipalOrgID}
aws:ResourceTag/prx:ops:environment: ${aws:PrincipalTag/prx:ops:environment}
Effect: Allow
Resource: !GetAtt CloudfrontRealTimeLogsStream.Arn
Principal:
AWS:
- "561178107736"
- !Ref AWS::AccountId
Version: "2012-10-17"

Outputs:
RealTimeLogsStreamArn:
Expand Down
3 changes: 2 additions & 1 deletion spire/templates/apps-100A.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,8 @@ Resources:
ArrangementsDynamodbRegion: !Sub /prx/${EnvironmentTypeAbbreviation}/dovetail-cdn-arranger/ARRANGEMENTS_DDB_REGION
ArrangementsDynamodbTableName: !Sub /prx/${EnvironmentTypeAbbreviation}/dovetail-cdn-arranger/ARRANGEMENTS_DDB_TABLE
ArrangementsDynamodbAccessRoleArn: !Sub /prx/${EnvironmentTypeAbbreviation}/dovetail-cdn-arranger/ARRANGEMENTS_DDB_ACCESS_ROLE
DovetailCdnLogsKinesisStreamArn: !Ref DovetailCdnLogsKinesisStreamArn
DovetailCdnLogsKinesisStreamArn: !Sub /prx/${EnvironmentTypeAbbreviation}/Spire/Dovetail-Counts/cdn-logs-kinesis-stream-arn-${AWS::Region}
OldDovetailCdnLogsKinesisStreamArn: !Ref DovetailCdnLogsKinesisStreamArn
DovetailCountedKinesisStreamArn: !Ref DovetailCountedKinesisStreamArn
DovetailRedisClientSecurityGroupId: !Ref DovetailRedisClientSecurityGroupId
DovetailRedisReplicationGroupEndpointAddress: !Ref DovetailRedisReplicationGroupEndpointAddress
Expand Down
11 changes: 10 additions & 1 deletion spire/templates/apps/dovetail-counts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ Parameters:
ArrangementsDynamodbRegion: { Type: AWS::SSM::Parameter::Value<String> }
ArrangementsDynamodbTableName: { Type: AWS::SSM::Parameter::Value<String> }
ArrangementsDynamodbAccessRoleArn: { Type: AWS::SSM::Parameter::Value<String> }
DovetailCdnLogsKinesisStreamArn: { Type: String }
DovetailCdnLogsKinesisStreamArn: { Type: AWS::SSM::Parameter::Value<String> }
OldDovetailCdnLogsKinesisStreamArn: { Type: String }
DovetailCountedKinesisStreamArn: { Type: String }
DovetailRedisReplicationGroupEndpointAddress: { Type: String }
DovetailRedisReplicationGroupEndpointPort: { Type: String }
Expand Down Expand Up @@ -88,6 +89,14 @@ Resources:
BisectBatchOnFunctionError: true
Enabled: true
StartingPosition: LATEST
Stream: !Ref OldDovetailCdnLogsKinesisStreamArn
Type: Kinesis
CountsBytesKinesisStreamTrigger:
Properties:
BatchSize: 100
BisectBatchOnFunctionError: true
Enabled: !If [IsProduction, false, true]
StartingPosition: LATEST
Stream: !Ref DovetailCdnLogsKinesisStreamArn
Type: Kinesis
Handler: index.handler
Expand Down