Set default values for normalized position to -1

[mbedda]

Setting 0 was getting omitted

Credit: Evora

[evs-ptr]

It was discussed in the discord channel. The reason for this PR is to allow developers to actually set VerticalNormalizedPosition and HorizontalNormalizedPosition to 0 value.

It didn't work before because JSON serializer omitted 0 value cause of default value handling. But setting DefaultValue attribute to -1 and actual value -1 by default will allow developers to explicitly set whatever value they want between 0 and 1.

-1 is invalid, according to unity, at any case for those two, so should be safe to use it as default value marker. If set to -1 JSON serializer will ignore this property now.

https://github.com/Facepunch/Rust.Community/blob/f1eef905473105e7814b984bc5745d4d9cbaa006/CommunityEntity.UI.cs#L809
https://docs.unity3d.com/2018.1/Documentation/ScriptReference/UI.ScrollRect-horizontalNormalizedPosition.html
https://docs.unity3d.com/2018.1/Documentation/ScriptReference/UI.ScrollRect-verticalNormalizedPosition.html

[ads102003]

Hi, I might be missing something but is there a reason we are not looking to do something like this instead?

Suggested change

	[DefaultValue(-1f)]
	public float HorizontalNormalizedPosition { get; set; } = -1f;
	[JsonProperty("verticalNormalizedPosition")]
	public float VerticalNormalizedPosition { get; set; }
	[DefaultValue(-1f)]
	public float VerticalNormalizedPosition { get; set; } = -1f;
	public float? HorizontalNormalizedPosition { get; set; }
	[JsonProperty("verticalNormalizedPosition")]
	public float? VerticalNormalizedPosition { get; set; }

[mbedda]

That would work fine too. 👍

[evs-ptr]

Will work too.

[evs-ptr]

It was made like this only to avoid nullability of value types. But both approaches are valid.

[evs-ptr]

Nullable value types use more memory compared to just value type. Because it is being wrapped into Nullable struct. I don't have benchmarks, nor does it matter a lot.

[mbedda]

Yeah if you want me to commit your suggestion for easier merge I don't mind (or if you wanna do it manually), it would work fine both ways only difference is that they won't be able to set -1f with the original commit which can only be used to do some animation so exact value doesn't matter.

[ads102003]

Thanks :)