Merged
Conversation
- More extensive use of `FTransform` - Simplified skinning calculations - Fixed PickingRenderPass culling - Now properly supports custom outline shaders - Deprecated PRE_TRANSFORM_VERTICES - Removed auto-add SkinnedMeshRenderer when model changes
…terial didn't support it
- Add Describable::SetDescriptor() to atomically add-or-replace a descriptor - Use SetDescriptor in SkinningUtils::ApplyDescriptor, removing the redundant HasDescriptor/RemoveDescriptor/AddDescriptor pattern - Group SkinningRenderFeature's 7 loose state fields into two inner structs (UploadedPaletteState, BoundPaletteState) for clarity - Remove unused p_scene parameter from AssimpParser::ProcessMesh (was immediately suppressed with (void)p_scene) - Replace self-referential lambda in BuildSkeleton with a plain recursive free function in the anonymous namespace - Remove unused CSkinnedMeshRenderer::GetBoneMatrices() (non-transposed version was never called outside the class itself) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DEBONE removes bone data from meshes, making it incompatible with skeletal animation. Mirror the PRE_TRANSFORM_VERTICES pattern: only strip the flag when it is actually set, and emit a warning so the user knows why their flag was ignored. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to integrate work from
feature/skeletal_animationtomain.This PR adds:
Also adds:
#engine_featureshader keyword to hide a feature that is intended to be controlled by the engine from the material editorUpdated/added documentation:
To-Do
GetRealPathre-implementation for editor shaders Move editor actions to editor context #651SKINNING) should be handledMake sure frustum culling properly work with skinned meshes#engine_featurein wikiSetEnabled)Improveinline with how the material renderer is setupNotifyModelChange, maybe rely on the built-in event on theModelRenderer?Related Issue(s)
Fixes #302
Screenshots/GIFs
Write here.
Checklist