Remix - Use remappings file instead of import version pins #786
Remix - Use remappings file instead of import version pins #786ericglau merged 26 commits intoOpenZeppelin:masterfrom
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis PR removes the Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Changeset is not needed since these are internal-facing changes in the core packages. |
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
|
@SocketSecurity ignore-all |
Update "Open in Remix" to pass remappings in the Remix URL instead of rewriting generated imports with version pins, so Remix can write the remappings to
remappings.txt.Makes use of remix-project-org/remix-project#6454
High-level changes:
remappings.txt.@openzeppelin/uniswap-hooksto itssrc/directory for compatibility with current import paths.print-versionedpath in favor of remappings-based Remix loading.