Skip to content

Implement equal fields constraint in schema#407

Merged
luisa-beerboom merged 33 commits intoOpenSlides:mainfrom
luisa-beerboom:b-3379-fix-equal-fields
Apr 16, 2026
Merged

Implement equal fields constraint in schema#407
luisa-beerboom merged 33 commits intoOpenSlides:mainfrom
luisa-beerboom:b-3379-fix-equal-fields

Conversation

@luisa-beerboom
Copy link
Copy Markdown
Member

@luisa-beerboom luisa-beerboom commented Mar 4, 2026

See OpenSlides/openslides-backend#3379

TODOs aside from The Obvious™

  • Look into constraint triggers
  • What about constant models.yml field def? Doesn't seem to be handled in any way?
  • generate_sql_schema fails on option/content_object_id, bc it tries to get meeting_id of user
  • Changed some stuff about the schema generation that may impact generated field names. perhaps ask @peb-adr how to potentially deal with that or change it back -> Looked at it: Apparently it was an edge case that wasn't present in our actual code to begin with.
  • CI fails
  • refactor and remove the debugging commands (all those print statements, etc)
  • cleanup

NOTES:

  • Possibly the option/content_object_id meeting_id-equal_fields might have not been previously checked for users

@luisa-beerboom luisa-beerboom force-pushed the b-3379-fix-equal-fields branch from 26d63b8 to 51dbe2b Compare March 5, 2026 15:31
@luisa-beerboom luisa-beerboom requested a review from hjanott March 23, 2026 10:05
@luisa-beerboom luisa-beerboom marked this pull request as ready for review March 23, 2026 10:07
@vkrasnovyd
Copy link
Copy Markdown
Contributor

Resolves #294

Comment thread dev/src/validate.py Outdated
Copy link
Copy Markdown
Contributor

@vkrasnovyd vkrasnovyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked only the updated trigger names generation (the change that I've requested). That's exactly what I wanted to see.

@vkrasnovyd vkrasnovyd removed their assignment Apr 15, 2026
Copy link
Copy Markdown
Member

@hjanott hjanott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the hard work. Looks ready for me now.

@hjanott hjanott assigned luisa-beerboom and unassigned hjanott Apr 16, 2026
@luisa-beerboom luisa-beerboom merged commit a244a21 into OpenSlides:main Apr 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants