Skip to content

Adjust same space for change recommendations#6000

Open
Borreg0 wants to merge 3 commits intoOpenSlides:mainfrom
Borreg0:5915-TooMuchSpaceInReco
Open

Adjust same space for change recommendations#6000
Borreg0 wants to merge 3 commits intoOpenSlides:mainfrom
Borreg0:5915-TooMuchSpaceInReco

Conversation

@Borreg0
Copy link
Contributor

@Borreg0 Borreg0 commented Mar 17, 2026

closes #5915

Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The space looks fine, but a strange bug occurs.

When I recreate the pull request with the change recommendation as described in the issue and then enter another change reco in the first line, lines 1 and 2 overlap.

To make sure this is a bug that only occurs in this pull request, I tested it on the current live version as well as on the internal 4.3-transitional branch. The problem does not occur in either version. I suspect there is a connection to this pull request.

To reproduce the error, a change reco must be entered in the first line. Whether words are deleted or added, the error occurs in

Here is a screenshot of the error:
Image

@MSoeb MSoeb assigned Borreg0 and unassigned Elblinator and MSoeb Mar 18, 2026
@Borreg0 Borreg0 assigned bastianjoel and MSoeb and unassigned Borreg0 Mar 19, 2026
@Borreg0 Borreg0 requested a review from MSoeb March 21, 2026 18:08
@Elblinator Elblinator assigned Elblinator and MSoeb and unassigned bastianjoel and MSoeb Mar 24, 2026
Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found other points, that need to be fixed:

1. Change Recommendation on two or more lines results in invisible lines. Reproduction: Select first two lines for change reco and delete a word. Save it. Second line won't be visible anymore. Here images:

Content before change reco:
Image

Content after change reco - line two is invisible.
Image

What should happen: All lines should be visible.

2. Broken change reco from current change request appears again in content below the change recommendation:

Image - Added Change Reco in line 6 and deleted a random word:
Image

--> What should happen: The broken change recos should not happen.

@MSoeb MSoeb assigned Borreg0 and unassigned Elblinator and MSoeb Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change reco: Too much space used

5 participants