Skip to content

chore(spp_cel_event): promote to Beta#16

Open
emjay0921 wants to merge 1 commit into19.0from
chore/spp-cel-event-beta
Open

chore(spp_cel_event): promote to Beta#16
emjay0921 wants to merge 1 commit into19.0from
chore/spp-cel-event-beta

Conversation

@emjay0921
Copy link
Contributor

@emjay0921 emjay0921 commented Feb 6, 2026

Why is this change needed?

Module has been manually tested and confirmed working. All core CEL event expressions return expected results. Promoting from Alpha to Beta.

How was the change implemented?

Changed development_status from "Alpha" to "Beta" in __manifest__.py.

New unit tests

Unit tests executed by the author

All 102 spp_cel_event tests pass (0 failed, 0 errors).

How to test manually

  1. Create event types (e.g., vulnerability_assessment, training, verification)
  2. Create event data records with JSON data (e.g., vulnerability_score, monthly_income, hours_completed)
  3. Create CEL variables (Studio > Rules > Variables) with aggregate target "Events":
    • vulnerability_score — event value from vulnerability_assessment
    • training_count — count of training events this year
    • total_training_hours — sum of hours_completed across trainings
    • has_verification — exists check for verification events
    • avg_training_score — average of training scores
  4. Use CEL expressions in program eligibility rules:
    • event('vulnerability_assessment', 'vulnerability_score') > 70
    • has_event('verification')
    • events_count('training') >= 3
    • event('vulnerability_assessment', 'monthly_income') < 5000
    • has_event('training', within_days=60)
    • events_count('training', period=this_year()) >= 2
  5. Preview eligibility to confirm correct registrant matches

Related links

@gemini-code-assist
Copy link

Summary of Changes

Hello @emjay0921, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request promotes the spp_cel_event module to Beta status. This advancement signifies that the module has undergone extensive manual and automated testing, with all core functionalities confirmed to be working as expected. The change primarily involves updating metadata and documentation to reflect this enhanced maturity, making the module more suitable for production environments.

Highlights

  • Module Promotion: The spp_cel_event module has been promoted from Alpha to Beta development status, indicating increased stability and readiness for broader use.
  • Configuration Update: The development_status in the __manifest__.py file was updated from "Alpha" to "Beta" to reflect the new maturity level.
  • Documentation Alignment: The README.rst and index.html documentation files were updated to change the maturity badge from "Alpha" to "Beta" and remove the associated "IMPORTANT" warning about alpha status.
Changelog
  • spp_cel_event/README.rst
    • Updated the maturity badge from "Alpha" (red) to "Beta" (yellow).
    • Removed the "IMPORTANT" warning block that advised against using the module in production due to its alpha status.
    • Adjusted indentation for list items in "Key Capabilities", "UI Location", and "Extension Points" sections.
  • spp_cel_event/manifest.py
    • Modified the development_status field from "Alpha" to "Beta".
  • spp_cel_event/static/description/index.html
    • Updated the maturity badge image source and alt text from "Alpha" to "Beta".
    • Removed the HTML block corresponding to the "Important" alpha version warning.
    • Adjusted indentation for list items in "Key Capabilities", "UI Location", and "Extension Points" sections.
Activity
  • The module underwent manual testing, confirming all functionalities.
  • All 6 core CEL event expressions were tested and returned expected results.
  • All 102 spp_cel_event unit tests passed without failures or errors.
  • Manual testing was performed against demo data, including 10 registrants and 54 event records, validating various CEL expressions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request promotes the spp_cel_event module from Alpha to Beta status. The changes correctly update the development status in __manifest__.py and adjust the documentation in README.rst and the generated index.html file by updating the maturity badge and removing the Alpha-specific warnings. My main feedback is to consider adding a new warning appropriate for the Beta status to manage user expectations regarding data model stability, as per Odoo Community Association guidelines.

~~~~~~~~~~~~

``spp_cel_domain``, ``spp_event_data``, ``spp_studio``

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While promoting to Beta is a great step, it's good practice to still include a warning about the development status. According to the Odoo Community Association guidelines, a Beta version's data model is not yet stable. Consider adding a note to inform users about this, similar to the one that was removed for the Alpha status.

Suggested change
.. IMPORTANT::
This is a beta version. The data model is not yet stable and may change in future versions.
It is not recommended to use this version in a production environment without thorough testing.
`More details on development status <https://odoo-community.org/page/development-status>`_

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant