Conversation
Summary of ChangesHello @emjay0921, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request promotes the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request promotes the spp_cel_event module from Alpha to Beta status. The changes correctly update the development status in __manifest__.py and adjust the documentation in README.rst and the generated index.html file by updating the maturity badge and removing the Alpha-specific warnings. My main feedback is to consider adding a new warning appropriate for the Beta status to manage user expectations regarding data model stability, as per Odoo Community Association guidelines.
| ~~~~~~~~~~~~ | ||
|
|
||
| ``spp_cel_domain``, ``spp_event_data``, ``spp_studio`` | ||
|
|
There was a problem hiding this comment.
While promoting to Beta is a great step, it's good practice to still include a warning about the development status. According to the Odoo Community Association guidelines, a Beta version's data model is not yet stable. Consider adding a note to inform users about this, similar to the one that was removed for the Alpha status.
| .. IMPORTANT:: | |
| This is a beta version. The data model is not yet stable and may change in future versions. | |
| It is not recommended to use this version in a production environment without thorough testing. | |
| `More details on development status <https://odoo-community.org/page/development-status>`_ | |
Why is this change needed?
Module has been manually tested and confirmed working. All core CEL event expressions return expected results. Promoting from Alpha to Beta.
How was the change implemented?
Changed
development_statusfrom"Alpha"to"Beta"in__manifest__.py.New unit tests
Unit tests executed by the author
All 102 spp_cel_event tests pass (0 failed, 0 errors).
How to test manually
vulnerability_score— event value from vulnerability_assessmenttraining_count— count of training events this yeartotal_training_hours— sum of hours_completed across trainingshas_verification— exists check for verification eventsavg_training_score— average of training scoresevent('vulnerability_assessment', 'vulnerability_score') > 70has_event('verification')events_count('training') >= 3event('vulnerability_assessment', 'monthly_income') < 5000has_event('training', within_days=60)events_count('training', period=this_year()) >= 2Related links