rtp.io: hook the OpenSIPS notification socket automatically#3674
Draft
sobomax wants to merge 7 commits intoOpenSIPS:masterfrom
Draft
rtp.io: hook the OpenSIPS notification socket automatically#3674sobomax wants to merge 7 commits intoOpenSIPS:masterfrom
sobomax wants to merge 7 commits intoOpenSIPS:masterfrom
Conversation
sobomax
force-pushed
the
pr_rtp_io_notifications
branch
from
ce9ab1b to
14c89d0
Compare
struct rtpp_sock to keep FD and type.
Allocate a single notification socketpair to be shared by all opensips workers, pass one side to the hosted rtpproxy process and provide API for the rtpproxy module to tap into the other end.
Do it when rtp.io is enabled. Start notification listener process always, turn it into dummy if rtp.io is not enabled and notification socket is not configured either.
sobomax
force-pushed
the
pr_rtp_io_notifications
branch
from
14c89d0 to
483b4d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtp.io: hook the OpenSIPS notification socket automatically.
Details
In the current version of the rtp.io, the notification socket still needs to be configured manually in both rtp.io and rtpproxy modules.
Solution
This patch is expected to fix that by allocating extra socketpair and passing that to the librtpproxy and rtpproxy module.
Compatibility
Existing configuration should work as is.