Conversation
bougue-pe
reviewed
Mar 18, 2026
bougue-pe
reviewed
Mar 18, 2026
11 tasks
otherwise during `TestDistanceRangeMap.testEmptyEntry` the map would end up having `bounds.size==1` and `values.size==0` instead of having both cleared. Signed-off-by: Hubert Hirtz <hubert@hirtz.pm>
hhirtz
force-pushed
the
uber/get
branch
2 times, most recently
from
5696203 to
7d86d8c
Compare
bougue-pe
approved these changes
Mar 30, 2026
Contributor
bougue-pe
left a comment
bougue-pe
left a comment
There was a problem hiding this comment.
Thanks for dealing with and improving the legacy ❤️
Signed-off-by: Hubert Hirtz <hubert@hirtz.pm>
Signed-off-by: Hubert Hirtz <hubert@hirtz.pm>
bougue-pe
approved these changes
Mar 31, 2026
Contributor
bougue-pe
left a comment
bougue-pe
left a comment
There was a problem hiding this comment.
OK to merge or to wait and push for "cleaner" bound management (but we probably won't dig on ETCS in the next 4 weeks).
Member
Author
|
Opened #16020 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also filter empty ranges in
DistanceRangeMap.putMany, otherwise duringTestDistanceRangeMap.testEmptyEntrythe map would end up havingbounds.size==1andvalues.size==0instead of having both cleared.