Skip to content

fix: disable Arrow S3 on Windows to avoid OpenSSL error#180

Merged
timosachsenberg merged 1 commit intomasterfrom
fix/arrow-windows-openssl
Mar 25, 2026
Merged

fix: disable Arrow S3 on Windows to avoid OpenSSL error#180
timosachsenberg merged 1 commit intomasterfrom
fix/arrow-windows-openssl

Conversation

@timosachsenberg
Copy link
Contributor

@timosachsenberg timosachsenberg commented Mar 25, 2026

Summary

  • Disables ARROW_S3 on Windows (MSVC) to fix the OpenSSL::Crypto target-not-found error during Arrow's CMake configure step
  • Removes the now-unnecessary AWSSDK_SOURCE=BUNDLED on Windows (only needed for S3)
  • S3 support remains enabled on Linux/macOS where OpenSSL is available as a system package

This mirrors how curl.cmake already avoids OpenSSL on Windows by using Schannel instead.

Fixes #178

Test plan

  • Verify Windows CI build passes (Arrow configure + build)
  • Verify Linux/macOS CI builds still pass with S3 enabled

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Windows builds no longer include AWS S3 support (Linux and macOS builds remain unchanged).

Arrow S3 requires AWS SDK which depends on OpenSSL::Crypto, but OpenSSL
is not available on Windows builds. This mirrors how curl.cmake already
uses Schannel instead of OpenSSL on Windows. S3 support remains enabled
on Linux/macOS.

Fixes #178

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 75df43f8-4e95-4c4c-8a3d-e6503ad7e4bb

📥 Commits

Reviewing files that changed from the base of the PR and between 186aacf and 407316c.

📒 Files selected for processing (1)
  • libraries.cmake/arrow.cmake

📝 Walkthrough

Walkthrough

This change modifies the Arrow CMake build configuration for Windows/MSVC platforms by disabling AWS S3 support and removing references to the bundled AWS SDK, while Linux/macOS configurations remain unchanged. This addresses a build failure on Windows related to missing OpenSSL dependencies.

Changes

Cohort / File(s) Summary
Arrow Windows Build Configuration
libraries.cmake/arrow.cmake
Disabled AWS S3 support (ARROW_S3=OFF) and removed bundled AWS SDK configuration (AWSSDK_SOURCE=BUNDLED) for MSVC/Windows builds to resolve OpenSSL dependency linking errors.

Possibly related PRs

  • PR #173: Modifies the same Arrow CMake configuration file but enables S3 support with bundled AWS SDK, representing the inverse approach to the changes made here.

Poem

🐰 Windows builds were troubled, with errors in the night,
So we turned off S3, and made the linking right,
No bundled SDK, just a simpler, cleaner way,
Now Arrow builds on Windows, hip hip hooray! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: disabling Arrow S3 on Windows to resolve an OpenSSL error, which directly addresses the primary objective of the PR.
Linked Issues check ✅ Passed The PR successfully addresses issue #178 by disabling ARROW_S3 on Windows to eliminate the OpenSSL::Crypto dependency that was causing the CMake configure failure.
Out of Scope Changes check ✅ Passed All changes are directly scoped to the Arrow S3 configuration on Windows; no unrelated modifications to other components or platforms are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/arrow-windows-openssl

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@timosachsenberg timosachsenberg merged commit 46a6481 into master Mar 25, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

building ARROW via contrib on Windows fails

1 participant