fix: disable Arrow S3 on Windows to avoid OpenSSL error#180
fix: disable Arrow S3 on Windows to avoid OpenSSL error#180timosachsenberg merged 1 commit intomasterfrom
Conversation
Arrow S3 requires AWS SDK which depends on OpenSSL::Crypto, but OpenSSL is not available on Windows builds. This mirrors how curl.cmake already uses Schannel instead of OpenSSL on Windows. S3 support remains enabled on Linux/macOS. Fixes #178 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change modifies the Arrow CMake build configuration for Windows/MSVC platforms by disabling AWS S3 support and removing references to the bundled AWS SDK, while Linux/macOS configurations remain unchanged. This addresses a build failure on Windows related to missing OpenSSL dependencies. Changes
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
ARROW_S3on Windows (MSVC) to fix theOpenSSL::Cryptotarget-not-found error during Arrow's CMake configure stepAWSSDK_SOURCE=BUNDLEDon Windows (only needed for S3)This mirrors how
curl.cmakealready avoids OpenSSL on Windows by using Schannel instead.Fixes #178
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit