Skip to content

Version update #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wforney wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Version update #863

wforney wants to merge 11 commits into from

Conversation

@wforney
Copy link

@wforney wforney commented Sep 27, 2019

  • Updated all projects to VS 2019, .NET Framework 4.8, and latest Windows 10 target for the C++ project

@nvella
Copy link
Member

nvella commented Sep 27, 2019

Hi @wforney, seems mostly solid. There are a few errors in the CI build as it's still running 2017, appveyor.yml and build.ps1 may need to be updated. https://ci.appveyor.com/project/dotnetfoundation/openlivewriter/builds/27712275#L246

@nvella nvella mentioned this pull request Oct 6, 2019
Closed
@nvella
Copy link
Member

nvella commented Oct 10, 2019

Hi @wforney, I found some docs which might help out;
https://github.com/microsoft/vssetup.powershell/blob/develop/docs/VSSetup/Select-VSSetupInstance.md#-version

It might be worth changing the version specifier from [15.0,16.0) to [16.0,17.0) - this specifies exactly v16 (Visual Studio 2019). Cheers 👍

@jongalloway jongalloway requested a review from Copilot January 16, 2026 23:36
Copilot AI reviewed Jan 16, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the OpenLiveWriter project from Visual Studio 2017 to Visual Studio 2019, upgrades all .NET Framework projects from version 4.6.1/4.7.2 to 4.8, and updates the C++ project to use the latest Windows 10 SDK (10.0) with the v142 platform toolset.

Changes:

  • Updated C++ project to use Windows SDK 10.0 and Visual Studio 2019 toolset (v142)
  • Upgraded all managed projects to target .NET Framework 4.8
  • Updated build infrastructure (build.ps1, appveyor.yml) to use Visual Studio 2019
  • Updated test dependencies (NUnit 3.4.1→3.12.0, ApprovalTests 3.0.11→4.2.2)

Reviewed changes

Copilot reviewed 45 out of 48 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
src/unmanaged/OpenLiveWriter.Ribbon/OpenLiveWriter.Ribbon.vcxproj Updated C++ project to Windows SDK 10.0 and v142 toolset
src/managed/writer.sln Added build script references to solution items
src/managed/*/*.csproj (multiple) Added TargetFrameworkVersion v4.8 to all managed projects
src/managed/*/app.config (multiple) Updated supportedRuntime to .NET Framework 4.8
src/managed/OpenLiveWriter.Tests/packages.config Updated NUnit and ApprovalTests packages to newer versions
build.ps1 Updated build script for VS 2019 (MSBuild path and error messages)
appveyor.yml Changed build image from VS 2017 to VS 2019
src/managed/LocEdit/Properties/*.Designer.cs Auto-generated code updated to VS 2019 tooling version
Files not reviewed (3)
  • src/managed/LocEdit/Properties/Resources.Designer.cs: Language not supported
  • src/managed/LocEdit/Properties/Settings.Designer.cs: Language not supported
  • src/managed/OpenLiveWriter.Localization/Images.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jongalloway
Apply suggestions from code review
078fe5e 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wforney and others added 3 commits January 18, 2026 17:13
@wforney
Update build.ps1
775c1c1 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@wforney
Merge remote-tracking branch 'upstream/master' into version-update
29f0109 
* upstream/master:
  Address PR feedback: fix block-level elements closing P and nested
  containers
  Fix artifact path: upload binaries instead of releases folder
  Fix GitHub Actions build: add .NET 4.6.1 dev pack and VS2022
  compatibility
  Add GitHub Actions CI workflow
  Add VS2026 support and make toolset selection flexible
  Update build scripts and C++ project for VS2019/VS2022 compatibility
  tests: Add unit tests for HtmlUtils.NormalizeHtmlClosingTags
  Fix paste to normalize HTML closing tags
  Add NormalizeHtmlClosingTags method to ensure optional-end-tag
  elements have closing tags
  Remove vscode settings.json
  openlivewriter.org => openlivewriter.org, see OpenLiveWriter#911
  Switch Default Blog endpoints to SSL

src/unmanaged/OpenLiveWriter.Ribbon/OpenLiveWriter.Ribbon.vcxproj

src/managed/OpenLiveWriter.BlogClient/Providers/BlogProviders.xml
src/managed/OpenLiveWriter.HtmlEditor/Linking/GlossaryManager.cs
src/managed/OpenLiveWriter.HtmlEditor/Marshalling/Data_Handlers/HtmlHandler.cs
src/managed/OpenLiveWriter.Tests/HtmlParser/HtmlNormalizationTests.cs
src/unmanaged/OpenLiveWriter.Ribbon/OpenLiveWriter.Ribbon.vcxproj
@wforney
Reformat app.config files to use tabs for indentation
35d74ac 
Updated all app.config files to use tabs instead of spaces for XML indentation. No configuration values or binding redirects were changed; only formatting was improved for consistency and readability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jongalloway jongalloway jongalloway approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wforney @nvella @jongalloway