-
Notifications
You must be signed in to change notification settings - Fork 0
Refactoring/rename binary ogd #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
khalifaT
wants to merge
8
commits into
chore/open-source-preparation
Choose a base branch
from
refactoring/rename-binary-ogd
base: chore/open-source-preparation
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6de97c5
delete hardocoded IP address
khalifaT 1fbda16
reslove precompile contract issue
khalifaT 7e467c5
provide registration steps
khalifaT 00f8474
refactor: rename binary from evmd to ogd
khalifaT 7165ea4
refactor: update scripts, configs, and docker setup for ogd rename
khalifaT 137af05
refactor: complete ogd rename - documentation, configs, and tests
khalifaT a0de916
refactoring makefile updates
khalifaT b644b08
keep evmd for v5.0 upgrade
khalifaT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,5 +20,6 @@ export default { | |
| }, | ||
| paths: { | ||
| sources: "./solidity", | ||
| exclude: ["**/lib/**"] | ||
| }, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| all: evmd-env | ||
| all: ogd-env | ||
|
|
||
| evmd-env: evmd-rmi | ||
| docker build --tag cosmos/evmd -f evmd-env/Dockerfile \ | ||
| ogd-env: ogd-rmi | ||
| docker build --tag cosmos/ogd -f ogd-env/Dockerfile \ | ||
| $(shell git rev-parse --show-toplevel) | ||
|
|
||
| evmd-rmi: | ||
| docker rmi cosmos/evmd 2>/dev/null; true | ||
| ogd-rmi: | ||
| docker rmi cosmos/ogd 2>/dev/null; true | ||
|
|
||
| .PHONY: all evmd-env evmd-rmi | ||
| .PHONY: all ogd-env ogd-rmi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,10 +25,10 @@ RUN adduser -D nonroot -u 1025 -G nonroot | |
| EXPOSE 26656 26657 1317 9090 26660 8545 8100 | ||
| STOPSIGNAL SIGTERM | ||
| VOLUME /evmd | ||
| WORKDIR /evmd | ||
| WORKDIR /ogd | ||
|
|
||
| # Copy the wrapper script and binary to expected locations | ||
| COPY contrib/images/evmd-env/wrapper.sh /usr/bin/wrapper.sh | ||
| COPY contrib/images/ogd-env/wrapper.sh /usr/bin/wrapper.sh | ||
| COPY test_deployment.sh /usr/bin/test_deployment.sh | ||
| COPY multi_node_startup.sh /usr/bin/multi_node_startup.sh | ||
| COPY --from=evmd-builder /work/build/evmd /evmd/ | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this could be an issue due to workdir diff |
||
|
|
||
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR description mentions updating localnet/docker targets for the renamed binary/image, but the top-level Makefile still has localnet targets that reference
contrib/images evmd-envandcosmos/evmd(see Makefile lines ~364-370). This looks like an incomplete rename and will preventmake localnet-build-env/make localnet-startfrom producing/using thecosmos/ogdimage as intended.