Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4134 +/- ##
==========================================
+ Coverage 88.79% 88.81% +0.01%
==========================================
Files 422 422
Lines 19189 19214 +25
==========================================
+ Hits 17038 17064 +26
+ Misses 2151 2150 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
elias-ba
changed the title
Add mix task and public API for creating pre-configured global OAuth clients. Supports --list to show config status, --only to select specific clients, and --email to specify the owner. Reads credentials from app config (Bootstrap/Dotenvy), skips unconfigured clients gracefully, and is fully idempotent.
elias-ba
force-pushed
the
demo-oauth-clients
branch
from
ed05211 to
ee036e9
Compare
Users can now create placeholder OAuth credentials that can be reauthorized later through the UI. Supports optional --project flag to attach credentials to a specific project.
Add `mix lightning.create_oauth_credential` for creating a single dummy OAuth credential with full control over name, user, and project. Replace bulk credential creation with a focused single-credential function (create_dummy_oauth_credential/3) that's composable and flexible.
Users can discover available OAuth clients before creating credentials. Shows client names, IDs, and whether they're global.
Add tests for both mix tasks (setup_demo_oauth_clients, create_oauth_credential) covering happy paths, error cases, and flag handling. Add direct tests for all_keys/0, env_vars_for/1, demo_client_name/1, and credential token body verification. 52 tests total, 0 failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing something that should make working on OAuth locally a bit easier and faster. This is not ready yet !