Open
Conversation
7 tasks
Collaborator
|
@taylordowns2000 I'm going to put out a worker patch today but I'm going to exclude this as we're waiting on the Lightning PR. I'll get this reviewed properly with a clear head tomorrow. |
Member
Author
|
that's perfect @josephjclark , thank you! if you do get the chance, a review before Thursday morning (730am Paris time) would be great as it would allow @stuartc and I to review your review when we talk about OpenFn/lightning#4531 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
When a workflow ends with a single leaf step whose dataclip is already persisted, send
final_dataclip_idinstead offinal_stateinrun:completeto avoid re-uploading state Lightning already has.Closes #1309 and best served after OpenFn/lightning#4531 is merged.
Implementation Details
lastDataclipIdwithleafDataclipIds[]onRunState, populated in step-complete only for steps with no downstream edges.final_dataclip_id; otherwise fall back to sendingfinal_stateas before.QA Notes
Branching workflows (multiple leaves) should still send final_state.
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Release branch checklist
Delete this section if this is not a release PR.
If this IS a release branch:
pnpm changeset versionfrom root to bump versionspnpm installpnpm changeset tagto generate tagsgit push --tagsTags may need updating if commits come in after the tags are first generated.