Include ServoDyn in Option 1 solve if structural controllers are enabled#3213
Open
deslaughter wants to merge 5 commits intoOpenFAST:devfrom
Open
Include ServoDyn in Option 1 solve if structural controllers are enabled#3213deslaughter wants to merge 5 commits intoOpenFAST:devfrom
deslaughter wants to merge 5 commits intoOpenFAST:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR integrates ServoDyn into the Option 1 implicit input-output solver when structural controllers are enabled, replacing the original Jacobian calculation routines with central difference methods. This change addresses instability issues in models with structural controllers (e.g., Wave Energy Converters). Additionally, Visual Studio project configurations were updated to fix Simulink build issues.
Changes:
- Added ServoDyn to Option 1 solve when structural controllers are active
- Replaced ServoDyn Jacobian calculation with central difference routines
- Updated Visual Studio project files for Matlab/Simulink builds
Reviewed changes
Copilot reviewed 36 out of 37 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/servodyn/src/ServoDyn_Types.f90 | Removed legacy Jacobian parameters from ServoDyn parameter type |
| modules/servodyn/src/ServoDyn_Registry.txt | Removed linearization parameter definitions from registry |
| modules/openfast-library/src/FAST_Solver.f90 | Added ServoDyn to Option 1 modules when structural controllers present, updated state update logic |
| modules/openfast-library/src/FAST_Funcs.f90 | Updated ServoDyn Jacobian function signatures to accept ModData%Vars |
| modules/awae/src/vtk.cpp | Changed loop counter type from unsigned to signed |
| vs-build/modules/*.vfproj (multiple) | Added Matlab_Debug and Matlab_Release configurations |
| vs-build/glue-codes/OpenFAST-Simulink.vfproj | Added additional source files to Simulink project |
| vs-build/OpenFAST.sln | Updated build configuration mappings for Matlab configurations and removed dependency |
| reg_tests/r-test | Updated subproject commit reference |
Comments suppressed due to low confidence (5)
vs-build/modules/WakeDynamics.vfproj:1
- Extraneous 's' character after closing Configuration tag. Remove the 's' to fix XML syntax.
vs-build/modules/VersionInfo.vfproj:1 - Extraneous 's' character after closing Configuration tag. Remove the 's' to fix XML syntax.
vs-build/modules/SubDyn.vfproj:1 - Extraneous 's' character after closing Configuration tag. Remove the 's' to fix XML syntax.
vs-build/modules/SoilDyn.vfproj:1 - Extraneous 's' character after closing Configuration tag. Remove the 's' to fix XML syntax.
vs-build/modules/SeaState.vfproj:1 - Missing 's' character after closing Configuration tag to match pattern in other files, or the 's' in other files should be removed. Verify correct XML syntax and ensure consistency.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrew-platt
approved these changes
Feb 19, 2026
Collaborator
andrew-platt
left a comment
There was a problem hiding this comment.
Thanks for addressing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge pending testing from @RBergua.
Feature or improvement description
This PR changes the glue code to add ServoDyn to the Option 1 implicit input-output solve for modules whose forces and accelerations significantly affect the structural dynamics of the model if any structural controllers are enabled in the module. As part of this improvement, the original ServoDyn Jacobian calculation routines were replaced with central difference routines to match the other modules which were revised during tight-coupling development. This change highlighted a couple of differences in the Jacobians, related to structural controllers, and several test baselines were updated as a result.
While processing this PR it was found that the Simulink build was no longer working for the Visual Studio projects, so they were modified to address this separate issue.
Related issue, if one exists
This feature was added as a result of discussion in #3189 where modeling a Wave Energy Converter failed because the model would quickly go unstable.
Impacted areas of the software
ServoDyn.f90FAST_Solver.f90Test results, if applicable