Keeptogethers adjust position relative to main icon #2501
Open
Ruzihm wants to merge 1 commit intoOpenDreamProject:masterfrom
Open
Keeptogethers adjust position relative to main icon #2501Ruzihm wants to merge 1 commit intoOpenDreamProject:masterfrom
Ruzihm wants to merge 1 commit intoOpenDreamProject:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a math error in calculating the
positionOffsetforProcessKeepTogethercalling intoDrawIconwhere each one was based off their own position instead of the main icon.Also, when rendering each set of keeptogethers, instead of just allocating a temp texture of the same size as the main icon, it uses one of the same size plus a border of 128 pixels for overlays which are larger than--or offset to an area outside of--the main icon. Future revisions could be smarter about this and actually calculate how much larger it needs to be, but this is a simple improvement.
Closes #1971
Issue #2500 is related but remains unfixed here. (although the cutoff problem shown there in the screenshot is alleviated)