Add install-openchami as part of openchami-release#52
Open
erl-hpe wants to merge 1 commit intoOpenCHAMI:mainfrom
Open
Add install-openchami as part of openchami-release#52erl-hpe wants to merge 1 commit intoOpenCHAMI:mainfrom
erl-hpe wants to merge 1 commit intoOpenCHAMI:mainfrom
Conversation
a37f01f to
464f834
Compare
579491b to
07ec0e9
Compare
Signed-off-by: Eric Lund <77127214+erl-hpe@users.noreply.github.com>
07ec0e9 to
94d1d75
Compare
adrianreber
reviewed
May 7, 2026
| fi | ||
|
|
||
| %post | ||
| # Create a shared python virtual environmnet in which to install |
There was a problem hiding this comment.
I am not from OpenCHAMI, but building a lot of RPMs for OpenHPC, so you definitely can ignore my comments. Having something like this in %post would be something I do not would want to see on my systems. I would not be happy to have some by RPM untracked files on my system installed. This looks like it will download the dependencies from the Internet.
This should happen inside the %build or %install section. But, I am not from OpenCHAMI, so just ignore it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Thank you for your contribution! Please ensure the following before submitting:
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryNOTE: I have taken advantage of the REUSE license sidecar mechanism for several files in this PR that are technically commentable where licensing comments would be inappropriate for one of two reasons:
install_openchami/install_openchami/templatesdirectory.install_openchami -bcommand and carrying Copyright / License information in that output is inconsistent with the intention of the command. The file in question isinstall_openchami/install_openchami/config/config.yaml.Description
This PR introduces a python package that implements an OpenCHAMI installation and deployment tool derived from the procedure described in the OpenCHAMI 2025 Tutorial and the work done in the
vtds-application-openchamiGitHub project. This iteration of the tool provides a mechanism by which a developer can quickly deploy OpenCHAMI onto a host Virtual Machine or similar platform by invoking two simple commands and verify that OpenCHAMI deploys correctly and that a Virtual Compute Node (VM) co-resident on the OpenCHAMI Head Node will boot from OpenCHAMI and is accessible using SSH.The motivation behind this project is twofold:
vtds-application-openchamipackage, where maintenance of the mechanism as OpenCHAMI evolves is decoupled from that evolution and into the OpenCHAMI product itself where it can be naturally maintained as part of the product.The second goal will need to be completed in a future PR where deployment onto a "real" cluster with external nodes and networks is finalized, but this places a stake in the ground allowing that work to proceed.
There is a README.md in the
install_openchamisub-directory that covers the intent and use of this new feature.Fixes #53
Type of Change
For more info, see Contributing Guidelines.