Skip to content

[agent] chore: add github actions#155

Open
guillaumejparis wants to merge 10 commits into
mainfrom
gh_actions_ci
Open

[agent] chore: add github actions#155
guillaumejparis wants to merge 10 commits into
mainfrom
gh_actions_ci

Conversation

@guillaumejparis
Copy link
Copy Markdown
Member

Proposed changes

Testing Instructions

  1. Step-by-step how to test
  2. Environment or config notes

Related issues

  • Closes #ISSUE-NUMBER

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

Further comments

Comment thread .github/workflows/agent-ci.yml Outdated
Comment thread .github/workflows/agent-ci.yml Outdated
Copilot AI review requested due to automatic review settings May 19, 2026 12:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new GitHub Actions CI pipeline for the agent (multi-OS/multi-arch build, lint, audit, tests, and optional artifact publishing), and includes small Rust error-handling/logging cleanups to avoid unwrap_err() patterns.

Changes:

  • Introduce .github/workflows/agent-ci.yml to build/test/lint/audit across Linux/Windows/macOS (x86_64 + arm64) and publish artifacts to JFrog on push.
  • Refactor a few Result handling blocks to use match / if let Err(...) patterns and improve logged error formatting.
  • Add a targeted Clippy allow for too_many_arguments on the keep-alive ping function.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/process/keep_alive.rs Avoids unwrap_err() in the keep-alive register loop; adds Clippy allow for argument count.
src/process/agent_job.rs Simplifies job polling Result handling via match.
src/api/register_agent.rs Logs registration HTTP errors without redundant to_string() in the log call.
src/api/manage_jobs.rs Logs list/clean job HTTP errors without redundant to_string() in the log call.
.github/workflows/agent-ci.yml New CI workflow for formatting, clippy, audit, testing, building, installer creation, and JFrog publishing.
Comments suppressed due to low confidence (1)

.github/workflows/agent-ci.yml:177

  • Same issue as the cargo-audit step: on Windows the installed binary is typically cargo-cache.exe, so checking $HOME/.cargo/bin/cargo-cache (no .exe) can cause needless reinstalls. Make the existence check OS-aware (include .exe on Windows) or use an idempotent install approach to avoid paying the compile/install cost every run.
      - name: Install cargo cache
        run: |
          if [ -x "$HOME/.cargo/bin/cargo-cache" ] || [ -x "$USERPROFILE\.cargo\bin\cargo-cache.exe" ]; then
            echo "cargo-cache already installed."
          else
            cargo install cargo-cache --locked
          fi
        shell: bash

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

push:
branches: [main]
tags:
- "[0-9]+.[0-9]+.[0-9]+"
Comment thread .github/workflows/agent-ci.yml Outdated
Comment on lines +105 to +110
run: |
if [ -x "$HOME/.cargo/bin/cargo-audit" ] || [ -x "$USERPROFILE\.cargo\bin\cargo-audit.exe" ]; then
echo "cargo-audit already installed."
else
cargo install cargo-audit --locked
fi
@github-actions
Copy link
Copy Markdown

Thank you for your contribution. This PR is but one step away from being ready for merging: all commits must be PGP-signed. To get started, please see https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@guillaumejparis guillaumejparis linked an issue May 20, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate CI pipelines to GitHub Actions

3 participants