NanoXRP: Battery voltage function, resetbot improvements, fixed package.json#96
Open
SaintSampo wants to merge 3 commits into
Open
NanoXRP: Battery voltage function, resetbot improvements, fixed package.json#96SaintSampo wants to merge 3 commits into
SaintSampo wants to merge 3 commits into
Conversation
Replace the raw ADC threshold in Board.is_on with a voltage-based check (threshold 4.272 V) and add get_battery_voltage to read and convert ADC values. get_battery_voltage handles NanoXRP and RP2040 scaling and briefly toggles the VIN pin when needed. Also remove manual VIN pin reconfiguration from resetbot.py.
Include XRPLib/buzzer.py and XRPExamples/buzzer_examples.py in package urls so the buzzer module and its example are packaged, and increment package version from 2.1.3 to 2.1.4.
SaintSampo
changed the title
SaintSampo
changed the title
Replace the module-import check for XRPLib.buzzer with an explicit hardware capability check using hasattr(Pin.board, "BOARD_BUZZER") in XRPLib/resetbot.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the raw ADC threshold in Board.is_on with a voltage-based check (threshold 4.272 V) and add get_battery_voltage to read and convert ADC values. get_battery_voltage handles NanoXRP and RP2040 scaling and briefly toggles the VIN pin when needed. Also remove manual VIN pin reconfiguration from resetbot.py.