fix '$env:TEMP' path resolving issue#53
Open
GreatTeacherBasshead wants to merge 1 commit intoOneGet:developerfrom
Open
fix '$env:TEMP' path resolving issue#53GreatTeacherBasshead wants to merge 1 commit intoOneGet:developerfrom
GreatTeacherBasshead wants to merge 1 commit intoOneGet:developerfrom
Conversation
'$env:TEMP' can be resolved to DOS-style path, and then after 'Join-Path' the resulting literal path is invalid
Contributor
|
I am unable to repro this. I tested by joining a DOS-style path with another path, and Test-Path is able to correctly detect whether the path exists or not. |
Author
Contributor
|
What version of Windows and PowerShell are you using? I can't get this to repro (follwed the instructions above). |
Author
|
I have it both on Windows Server 2016 and 2019. I think the problem is in the user name. Try to test it for a user, who has a dot in the name, like I showed. |
|
FYI I'm experiencing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$env:TEMPcan be resolved to DOS-style path like 'C:\Users\ARZZ~1.BOK\AppData\Local\Temp', and then afterJoin-Paththe resulting literal path is invalid.If you
Test-Path $script:location_modules, you getfalsein this case.It causes that
remove-itemin line 334 fails the installation.