[Refactor] Introduce centralized ConfigManager for safe JSON access #2
Open
aviralsaxena16 wants to merge 2 commits intoOSIPI:mainfrom
Open
[Refactor] Introduce centralized ConfigManager for safe JSON access #2aviralsaxena16 wants to merge 2 commits intoOSIPI:mainfrom
aviralsaxena16 wants to merge 2 commits intoOSIPI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resubmitting this PR to the new repository per guidance.
Motivation
The GSoC project description specifies that model and fitting parameters should be driven via JSON configuration rather than hardcoded logic.
Currently, scripts directly use
json.load("config.json"), which can lead to runtimeKeyErrorcrashes if expected nested keys are missing.This PR introduces a lightweight
ConfigManagerutility that centralizes configuration loading and provides safe nested access via.get().What This PR Introduces
core/config_manager.pyjson.load()callsWhy This Approach
This is a minimal, non-breaking step toward the modular JSON-driven execution required by the GSoC project, while preserving full backward compatibility.
If this direction aligns with expectations, future iterations can introduce:
I welcome any feedback on this approach!