HYRAX-2021, check in the first version of find_needed_chunks_simple. …#1263
Closed
HYRAX-2021, check in the first version of find_needed_chunks_simple. …#1263
Conversation
…ith the subset case. A test is added to cover multiple cases.
…aller than the given stop index. Utilize this fact to find the selected chunks.
…e when the array contains many chunks.
… the case when the array contains many chunks." This reverts commit 476022b. It turns out the callgrind number becomes a little bigger for the testing cases. So no need to make the code more complicated when the performance doesn't get improved.
|
|
|
Collaborator
Author
|
Not needed. 1266 covers this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Just compile it.
Description
Reference ticket: HYRAX-####
TODO
Tasks