[18.0][FIX] account_invoice_import_facturx: Decrease line price_unit/price_subtotal by allowance/charge#1291
Open
mt-software-de wants to merge 3 commits intoOCA:18.0from
Conversation
Contributor
|
Hi @alexis-via, |
mt-software-de
force-pushed
the
18-fix-account_invoice_import_facturx-allowance
branch
2 times, most recently
from
916c17b to
62393e1
Compare
…subtotal by allowance/charge amount since LineTotalAmount is exclusive taxes but inclusive allowances/charges
mt-software-de
force-pushed
the
18-fix-account_invoice_import_facturx-allowance
branch
from
62393e1 to
b8690fe
Compare
mt-software-de
force-pushed
the
18-fix-account_invoice_import_facturx-allowance
branch
from
b8690fe to
443ccfa
Compare
…lowance or charge is created as separate line or not
mt-software-de
force-pushed
the
18-fix-account_invoice_import_facturx-allowance
branch
from
443ccfa to
8aae823
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since LineTotalAmount is exclusive taxes but inclusive allowances/charges.
We need to decrease the line's price_unit/price_subtotal. Otherwise it is reduced twice.
Also i implemented a config to either create a separate allowance/charge line or not.
The res.config.settings is still missing and tests.
@alexis-via thanks for this addon.
Here is the schema of LineTotalAmount.
https://portal3.gefeg.com/projectdata/invoice/deliverables/installed/publishingproject/zugferd%202.1%20-%20facturx%201.0.05/en%2016931%20%E2%80%93%20facturx%201.0.05%20%E2%80%93%20zugferd%202.1%20-%20basic.scm/html/DE/021.htm?https://portal3.gefeg.com/projectdata/invoice/deliverables/installed/publishingproject/zugferd%202.1%20-%20facturx%201.0.05/en%2016931%20%E2%80%93%20facturx%201.0.05%20%E2%80%93%20zugferd%202.1%20-%20basic.scm/html/DE/0250.htm