Skip to content

languages/csharp: add razor support#1498

Open
CaueAnjos wants to merge 1 commit intoNotAShelf:mainfrom
CaueAnjos:feat/razor-support
Open

languages/csharp: add razor support#1498
CaueAnjos wants to merge 1 commit intoNotAShelf:mainfrom
CaueAnjos:feat/razor-support

Conversation

@CaueAnjos
Copy link
Copy Markdown

@CaueAnjos CaueAnjos commented Apr 5, 2026

Adds razor support for roslyn and csharp_ls servers

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

@CaueAnjos
Copy link
Copy Markdown
Author

CaueAnjos commented Apr 5, 2026 •
edited
Loading

This pull request is the same as #1271, but with updated code. The branch feat/roslyn-ls was deleted by GitHub Actions, so I had to recreate the changes on a new branch and open a new pull request.

Sorry for the inconvenience.

@CaueAnjos CaueAnjos mentioned this pull request Apr 5, 2026
Closed
17 tasks
github-actions bot pushed a commit that referenced this pull request Apr 5, 2026
@actions-user
Deploy PR #1498 preview
31107a2
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026 •
edited
Loading

🚀 Live preview deployed from ba1fcf1

View it here:

Debug Information

Triggered by: CaueAnjos

HEAD at: feat/razor-support

Reruns: 2480

horriblename
horriblename reviewed Apr 7, 2026
View reviewed changes
horriblename
horriblename reviewed Apr 7, 2026
View reviewed changes
modules/plugins/languages/csharp.nix Outdated
# functionality, this will be the default.
defaultServers = ["csharp_ls"];
# NOTE: roslyn is the most feature-rich option, and its Razor integration is better than csharp-ls (which only supports .cshtml).
defaultServers = ["roslyn_ls"];
Copy link
Copy Markdown
Collaborator

@horriblename horriblename Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason for changing the default server anymore? since roslyn_ls alone also doesn't support razor right?

github-actions bot pushed a commit that referenced this pull request Apr 7, 2026
@actions-user
Deploy PR #1498 preview
3224220
@CaueAnjos CaueAnjos force-pushed the feat/razor-support branch from 00ccf7a to 0222767 Compare April 8, 2026 13:58
github-actions bot pushed a commit that referenced this pull request Apr 8, 2026
@actions-user
Deploy PR #1498 preview
16472d3
horriblename
horriblename requested changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@horriblename horriblename left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change, I promise :)

thanks for the work so far

modules/plugins/languages/csharp.nix Outdated
Comment on lines +306 to +311
event = [
{
event = "BufEnter";
pattern = ["*.cs" "*.razor"];
}
];
Copy link
Copy Markdown
Collaborator

@horriblename horriblename Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be lazy loaded, as upstream don't seem to recommend it themselves, and the plugin doesn't seem to do a whole lot at startup anyways

if you still think it's necessary, ft = ["c_sharp" "razor" "cshtml"] should be used I believe (spelling for c_sharp may be wrong idk)

@CaueAnjos CaueAnjos force-pushed the feat/razor-support branch from 0222767 to e0ff93e Compare April 8, 2026 17:30
github-actions bot pushed a commit that referenced this pull request Apr 8, 2026
@actions-user
Deploy PR #1498 preview
927e1ee
@CaueAnjos CaueAnjos force-pushed the feat/razor-support branch from e0ff93e to cbcd82a Compare April 9, 2026 14:17
github-actions bot pushed a commit that referenced this pull request Apr 9, 2026
@actions-user
Deploy PR #1498 preview
f099fd6
@CaueAnjos CaueAnjos force-pushed the feat/razor-support branch from cbcd82a to 8b7f710 Compare April 9, 2026 14:39
@CaueAnjos
languages/csharp: add razor support
9f8a0fd 
Adds razor support for `roslyn` and `csharp_ls` servers
@CaueAnjos CaueAnjos force-pushed the feat/razor-support branch from 8b7f710 to 9f8a0fd Compare April 9, 2026 14:42
github-actions bot pushed a commit that referenced this pull request Apr 9, 2026
@actions-user
Deploy PR #1498 preview
58c59c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@horriblename horriblename horriblename requested changes

@NotAShelf NotAShelf Awaiting requested review from NotAShelf NotAShelf is a code owner

@Soliprem Soliprem Awaiting requested review from Soliprem Soliprem is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

topic: documentation topic: modules topic: plugins

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CaueAnjos @horriblename