Conversation
poseidon-rises
requested review from
NotAShelf,
Soliprem and
horriblename
as code owners
horriblename
force-pushed
the
v0.8
branch
2 times, most recently
from
8b98f07 to
ba9ce8b
Compare
poseidon-rises
force-pushed
the
languages/fish
branch
from
43fb640 to
2cc95f5
Compare
|
I'll hold off on merging this till #1103 is merged |
poseidon-rises
force-pushed
the
languages/fish
branch
from
82aeb00 to
fe38561
Compare
|
|
poseidon-rises
force-pushed
the
languages/fish
branch
from
9c0fcd0 to
be146c0
Compare
Add fish support with fish-lsp and fish_indent.
poseidon-rises
force-pushed
the
languages/fish
branch
from
be146c0 to
e709fc3
Compare
NotAShelf
left a comment
NotAShelf
left a comment
There was a problem hiding this comment.
One blocker, lgtm afterwards.
|
@poseidon-rises the CI is failing because Nix is failing to evaluate |
Co-authored-by: raf <raf@notashelf.dev>
poseidon-rises
force-pushed
the
languages/fish
branch
from
9eab777 to
37e70a2
Compare
|
|
||
| defaultServers = [ "fish-lsp" ]; | ||
| servers = { | ||
| fish-lsp = { |
There was a problem hiding this comment.
LSPs now live under lsp/presets/<name> you should prolly rebase to latest main, and look at other modules and lsps
snoweuph
left a comment
snoweuph
left a comment
There was a problem hiding this comment.
on main, we also added more defaultText to enable options, that have defaults.
| formats = { | ||
| fish_indent = { | ||
| package = pkgs.fish; | ||
| config.command = "${cfg.format.package}/bin/fish_indent"; |
There was a problem hiding this comment.
this will break if any other formatter is used in the future.
use getExe' instead and don't access cfg.format.package, which doesnt always point at this, instead just call "${getExe' pkgs.fish "fish_indent"}"
5 participants
Add fish support with fish-lsp and fish_indent.
Rewrite of #807 using the new API as the original creator has stopped responding.
Sanity Checking
nix fmt).#nix(default package).#maximal.#docs-html(manual, must build).#docs-linkcheck(optional, please build if adding links)x86_64-linuxaarch64-linuxx86_64-darwinaarch64-darwinAdd a 👍 reaction to pull requests you find important.