Generalize BMS cell data model for arbitrary cell counts#528
Open
Generalize BMS cell data model for arbitrary cell counts#528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replaces all hardcoded BMS cell-count enums and fixed-length tuple types with a single config-driven
BMS_CONFIGobject (in newbms.config.tsfile). To support a different accumulator with different cell/segment counts, only the values inBMS_CONFIGneed to change — everything else derives from it.The refactoring:
Files changed: bms.config.ts (new), bms.utils.ts, topic.utils.ts, cell.service.ts, cell-by-cell-heat-map.component.ts
Test Cases
/bms/bms/segment/:id) navigates and renders correctlyng buildsucceeds with no new warningsChecklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
package-lock.jsonchanges (unless dependencies have changed)Closes #525