Fix type hints for EchoReader callbacks#22
Merged
JohnCHarrington merged 2 commits intorefactor-python-codefrom Feb 19, 2026
Merged
Fix type hints for EchoReader callbacks#22JohnCHarrington merged 2 commits intorefactor-python-codefrom
EchoReader callbacks#22JohnCHarrington merged 2 commits intorefactor-python-codefrom
Conversation
Co-authored-by: JohnCHarrington <1857365+JohnCHarrington@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on python code refactor and workflows enhancements
Fix type hints for Feb 19, 2026
EchoReader callbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depth_callbackwas annotated asCallable[[dict], Coroutine]but invoked with afloat, causing mypy errors and misleading callers.Coroutinereturn types were also left bare (no type parameters).Changes
depth_callback:Callable[[dict], Coroutine]→Callable[[float], Coroutine[Any, Any, None]]data_callback:Callable[[dict], Coroutine]→Callable[[dict], Coroutine[Any, Any, None]]from typing import Any💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.