feat(ipsec-tunnels): enhance table structure and add sorting functionality#728
Open
m-dilorenzi wants to merge 1 commit intomainfrom
Open
feat(ipsec-tunnels): enhance table structure and add sorting functionality#728m-dilorenzi wants to merge 1 commit intomainfrom
m-dilorenzi wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
TunnelTable.vuecomponent to improve its table rendering, sorting, and pagination features by leveraging new composables and UI components from@nethesis/vue-components. The update also unifies the usage of FontAwesome icons and enhances the visual feedback for tunnel states.Key improvements include:
Table Structure, Sorting, and Pagination:
NeTable,NeTableHead,NeTableBody, etc., for greater flexibility and accessibility. Sorting is now enabled viaNeSortDropdownanduseSort, and pagination is handled withNePaginatoranduseItemPagination.Visual and Icon Consistency:
font-awesome-iconcomponent to the explicitly importedFontAwesomeIconand named icon imports, ensuring consistency and improved maintainabilityCode Cleanup and Prop Handling:
getCellClasses) and switches to storing props in a variable, which is more idiomatic in<script setup>.Closes: NethServer/nethsecurity#1563