feat(ovpnrw): connections history from storage if available#720
Open
m-dilorenzi wants to merge 2 commits intomainfrom
Open
feat(ovpnrw): connections history from storage if available#720m-dilorenzi wants to merge 2 commits intomainfrom
m-dilorenzi wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the OpenVPN RW connections history feature to improve performance, usability, and code maintainability. The most significant changes include switching from local data filtering to server-side querying with pagination and sorting, updating the UI to handle asynchronous states, and simplifying component responsibilities.
Data fetching and filtering improvements:
ConnectionsHistory.vuewith server-side querying using@tanstack/vue-query, including debounced search, route-persisted filters, sorting, and pagination. This enables more efficient handling of large datasets and improves responsiveness.UI and component updates:
ConnectionsHistory.vueandUserConnectionsTable.vueto use new query state variables (isPending,isSuccess,isError, etc.) for displaying loading skeletons, error notifications, and empty states, improving user feedback and clarity.UserConnectionsTable.vueto receive paginated, sorted data and control parameters as props, removing internal sorting and pagination logic, and emitting events for parent control.Error handling and filter reset enhancements:
Closes: NethServer/nethsecurity#1404