respect fractional sizes in gcnv #1109
Open
+72
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
today gcnv completely discards fractional sizes and picks the floor from the 1Gi aligment result i.e. 10.6Gi results in 10Gi volume which does not satisfy the user request Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
Author
|
/cc @clintonk |
Author
|
would appreciate some guidance about the snapshot reserve bit alignment too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
today gcnv completely discards fractional sizes
and picks the floor from the 1Gi aligment result
i.e. 10.6Gi results in 10Gi volume which does not satisfy the user request
Fixes #1110
Project tracking
Do any added TODOs have an issue in the backlog?
Did you add unit tests? Why not?
Does this code need functional testing?
Is a code review walkthrough needed? why or why not?
Should additional test coverage be executed in addition to pre-merge?
Does this code need a note in the changelog?
Does this code require documentation changes?
Additional Information
Not 100% sure if I should tackle the calculation post snapshot reserve, would appreciate some guidelines